Fix extraLabels rendering #104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this has also kept me busy until i saw this PR |
|
Stale. closing this PR. labels and extraLabels is on our radar to review and fix up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #103
Please see the associated issue (#103) for details of the problem being addressed. I have tested this fix manually.
I also took the opportunity to harmonize and DRY the rendering of labels across all templates by moving the rendering of
extraLabelsinto the helper function. This should result in all resources having the same labels as before, with the exception of the iq-servertest-connectiontest pod, which will now also have theextraLabelson it.