Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update instrumentation to be compatible with Rails 7.2 #15

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Update instrumentation to be compatible with Rails 7.2 #15

wants to merge 2 commits into from
+62 −6

Conversation

inkstak
Copy link
Member

@inkstak inkstak commented Aug 21, 2024 •
edited
Loading

Since Rails 7.1, the instrumentation output the following warning :

DEPRECATION WARNING: Bolding log text with a positional boolean is deprecated and will be removed in Rails 7.2. Use an option hash instead (eg. `color("my text", :red, bold: true)`).

TODO:

  • Support ActiveSupport >= 7.1
  • Support ActiveSupport < 7.1
  • Add tests

@inkstak inkstak self-assigned this Aug 21, 2024
@inkstak inkstak force-pushed the bugfix-instrumentation branch from 87e9e13 to e9cb3bd Compare August 21, 2024 15:31
@inkstak inkstak added the enhancement New feature or request label Aug 21, 2024
@inkstak inkstak changed the base branch from main to upgrade-ci August 21, 2024 15:31
@inkstak inkstak marked this pull request as draft August 21, 2024 15:32
@inkstak inkstak force-pushed the upgrade-ci branch 3 times, most recently from 973e1b3 to 952ddb7 Compare August 27, 2024 20:03
Base automatically changed from upgrade-ci to main August 27, 2024 20:06
@inkstak inkstak force-pushed the bugfix-instrumentation branch from e9cb3bd to e67a6db Compare August 27, 2024 20:06
@inkstak inkstak force-pushed the bugfix-instrumentation branch from e67a6db to df47b5f Compare August 27, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@inkstak inkstak

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@inkstak