Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staying up to date #2

Open
timoxley opened this issue Oct 11, 2012 · 2 comments
Open

Staying up to date #2

timoxley opened this issue Oct 11, 2012 · 2 comments

Comments

@timoxley
Copy link

I'd like to use this component, but I don't have confidence the repo will be kept in sync with the official caolan/async… IMO having two independent repos is the worse than the problem components is trying to solve. It'd be better if this was simply a branch of the official async so anyone can easily PR updates. have you mentioned this to @caolan?

@sebs
Copy link
Member

sebs commented Oct 11, 2012

There Re several issues in tis.

  1. A clone.
    My Bad, i was just hacking together code for a own project at hat time. Surely I can clone the repo and go on from there.
  2. Compat.
    he code of the original lib needs a change, as long as this is the case there is not much the lriginal author can do. Its really ugly to pollute theoriginal, veryclean lib with he module.expors statement. I doubt it will find its way in the original codenase
  3. Mentioning
    I will mentoon it, after a clone to the original author and we will see whats happening.

@timoxley
Copy link
Author

Its really ugly to pollute theoriginal, veryclean lib with he module.expors statement

Agreed, a new branch in the original repo that contains the component compatible changes would fix this.

Surely I can clone the repo and go on from there.

Surely you can, but divergent codebases are bad since bug fixes and api changes won't necessarily align.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants