Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extracted parts which bikeshed can reuse across the specs #160

Merged
merged 2 commits into from
Mar 2, 2023

Conversation

elf-pavlik
Copy link
Member

@elf-pavlik elf-pavlik commented Mar 2, 2023

@elf-pavlik elf-pavlik requested a review from csarven March 2, 2023 13:28
Copy link
Member

@csarven csarven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested the changes (by building) but they look correct and as per agreement.

partials/terminology.bs Outdated Show resolved Hide resolved
Co-authored-by: Sarven Capadisli <[email protected]>
@elf-pavlik
Copy link
Member Author

elf-pavlik commented Mar 2, 2023

I run the build locally for both channel types. Automatic checks for all PRs will be taken care of in #156

@elf-pavlik elf-pavlik merged commit 5a46828 into solid:main Mar 2, 2023
@elf-pavlik elf-pavlik deleted the partials branch March 2, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants