Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2 matcher not working with net/http #95

Open
lukeo3o1 opened this issue Sep 29, 2022 · 2 comments · May be fixed by #96
Open

http2 matcher not working with net/http #95

lukeo3o1 opened this issue Sep 29, 2022 · 2 comments · May be fixed by #96

Comments

@lukeo3o1
Copy link

Caused by golang/go#55076

https://github.com/golang/go/blob/9861e8b2fd83dec24a6ced44998dca52abd6ccff/src/net/http/server.go#L1854

@lukeo3o1 lukeo3o1 linked a pull request Sep 29, 2022 that will close this issue
@AttilaTheFun
Copy link

Hi @lukeo3o1 ! I have a Go server that currently uses gRPC internally on a different port than the publicly accessible HTTP port. I’m interested in exposing some gRPC services publicly through the same port and I’m considering using cmux for this, I don’t want to sacrifice HTTP/2 support.

I see you have a branch for this but it hasn’t been updated in a few months. What is the current status of this feature? If it’s workable / close to shipping I’d like to try it out. If not I’ll probably have to set up a separate subdomain for the gRPC APIs.

@lukeo3o1
Copy link
Author

Hi @AttilaTheFun

I am using this feature in production and it has been workable for me. However, I have occasionally encountered PROTOCOL_ERROR errors. Although these occurrences are rare, I recommend testing the feature thoroughly and using it at your own discretion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants