Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: invalidate ClipPath after saveDefinition #2474

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

bohdanprog
Copy link
Member

Summary

Closes #2473 #1719

Compatibility

ClipPath wasn't invalidated after defining clipPath.
Now, everything worked.

OS Implemented
iOS
MacOS
Android

@bohdanprog bohdanprog self-assigned this Oct 3, 2024
@bohdanprog bohdanprog changed the title feat: add test case feat: invalidate ClipPath after saveDefinition Oct 3, 2024
@bohdanprog bohdanprog requested a review from jakex7 October 4, 2024 09:57
Copy link
Member

@jakex7 jakex7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is it a correct solution? Why saveDefinition is called when Rect's height is updated?

android/src/main/java/com/horcrux/svg/ClipPathView.java Outdated Show resolved Hide resolved
@bohdanprog
Copy link
Member Author

How is it a correct solution? Why saveDefinition is called when Rect's height is updated?

Without invalidate in safeDefinition ClipPah it doesn't render anything inside ClipPath component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Animated ClipPaths not re-rendering on Android
2 participants