From 74f09dc4b7d69ea3bc42b3bf64fdb3a9cf3c29d1 Mon Sep 17 00:00:00 2001
From: Maciej Makowski <maciej.makowski@swmansion.com>
Date: Tue, 23 Jul 2024 11:25:11 +0200
Subject: [PATCH 1/7] feat: implemented gain node

---
 android/CMakeLists.txt                        |  6 +++
 android/src/main/cpp/AudioContext.cpp         | 11 +++-
 android/src/main/cpp/AudioContext.h           |  4 +-
 android/src/main/cpp/GainNode.cpp             | 16 ++++++
 android/src/main/cpp/GainNode.h               | 23 +++++++++
 .../com/audiocontext/context/AudioContext.kt  |  5 ++
 .../audiocontext/context/BaseAudioContext.kt  |  2 +
 .../java/com/audiocontext/nodes/GainNode.kt   | 22 ++++++++
 cpp/AudioContext/AudioContextHostObject.cpp   |  8 +++
 cpp/AudioContext/AudioContextHostObject.h     |  1 +
 cpp/AudioContext/AudioContextWrapper.h        |  2 +
 .../android/AudioContextWrapper.cpp           |  5 ++
 cpp/GainNode/GainNodeHostObject.cpp           | 51 +++++++++++++++++++
 cpp/GainNode/GainNodeHostObject.h             | 27 ++++++++++
 cpp/GainNode/GainNodeWrapper.h                | 33 ++++++++++++
 cpp/GainNode/android/GainNodeWrapper.cpp      | 12 +++++
 cpp/GainNode/ios/.keep                        |  0
 example/src/App.tsx                           | 42 ++++++++-------
 src/index.ts                                  |  7 ++-
 src/types.ts                                  |  5 ++
 20 files changed, 260 insertions(+), 22 deletions(-)
 create mode 100644 android/src/main/cpp/GainNode.cpp
 create mode 100644 android/src/main/cpp/GainNode.h
 create mode 100644 android/src/main/java/com/audiocontext/nodes/GainNode.kt
 create mode 100644 cpp/GainNode/GainNodeHostObject.cpp
 create mode 100644 cpp/GainNode/GainNodeHostObject.h
 create mode 100644 cpp/GainNode/GainNodeWrapper.h
 create mode 100644 cpp/GainNode/android/GainNodeWrapper.cpp
 create mode 100644 cpp/GainNode/ios/.keep

diff --git a/android/CMakeLists.txt b/android/CMakeLists.txt
index 329e3836..2ba14671 100644
--- a/android/CMakeLists.txt
+++ b/android/CMakeLists.txt
@@ -17,6 +17,7 @@ include_directories(
         ../cpp/AudioDestinationNode
         ../cpp/OscillatorNode
         ../cpp/AudioNode
+        ../cpp/GainNode
         src/main/cpp
         ../node_modules/react-native/ReactCommon/jsi
         ../node_modules/react-native/ReactAndroid/src/main/jni/react/jni
@@ -29,6 +30,7 @@ add_library(react-native-audio-context SHARED
         src/main/cpp/OscillatorNode
         src/main/cpp/AudioDestinationNode
         src/main/cpp/AudioNode
+        src/main/cpp/GainNode
 
         ../cpp/AudioContext/AudioContextHostObject
         ../cpp/AudioContext/AudioContextWrapper.h
@@ -45,6 +47,10 @@ add_library(react-native-audio-context SHARED
         ../cpp/AudioNode/AudioNodeHostObject.h
         ../cpp/AudioNode/AudioNodeWrapper.h
         ../cpp/AudioNode/android/AudioNodeWrapper.cpp
+
+        ../cpp/GainNode/GainNodeHostObject
+        ../cpp/GainNode/GainNodeWrapper.h
+        ../cpp/GainNode/android/GainNodeWrapper.cpp
 )
 
 find_package(ReactAndroid REQUIRED CONFIG)
diff --git a/android/src/main/cpp/AudioContext.cpp b/android/src/main/cpp/AudioContext.cpp
index ebe88894..a925a2d6 100644
--- a/android/src/main/cpp/AudioContext.cpp
+++ b/android/src/main/cpp/AudioContext.cpp
@@ -22,7 +22,7 @@ namespace audiocontext
     return std::shared_ptr<OscillatorNode>(oscillatorCppInstance);
   }
 
-    std::shared_ptr<AudioDestinationNode> AudioContext::getDestination()
+  std::shared_ptr<AudioDestinationNode> AudioContext::getDestination()
   {
     static const auto method = javaClassLocal()->getMethod<AudioDestinationNode()>("getDestination");
     auto destination = method(javaObject_.get());
@@ -31,4 +31,13 @@ namespace audiocontext
     return std::shared_ptr<AudioDestinationNode>(destinationCppInstance);
   }
 
+    std::shared_ptr<GainNode> AudioContext::createGain()
+    {
+        static const auto method = javaClassLocal()->getMethod<GainNode()>("createGain");
+        auto gain = method(javaObject_.get());
+        auto gainCppInstance = gain->cthis();
+
+        return std::shared_ptr<GainNode>(gainCppInstance);
+    }
+
 } // namespace audiocontext
diff --git a/android/src/main/cpp/AudioContext.h b/android/src/main/cpp/AudioContext.h
index 00982fd8..358fdb69 100644
--- a/android/src/main/cpp/AudioContext.h
+++ b/android/src/main/cpp/AudioContext.h
@@ -6,9 +6,10 @@
 #include <react/jni/JMessageQueueThread.h>
 #include <memory>
 #include "AudioContextHostObject.h"
+#include "AudioContextWrapper.h"
 #include "OscillatorNode.h"
 #include "AudioDestinationNode.h"
-#include "AudioContextWrapper.h"
+#include "GainNode.h"
 
 namespace audiocontext
 {
@@ -39,6 +40,7 @@ namespace audiocontext
 
     std::shared_ptr<OscillatorNode> createOscillator();
     std::shared_ptr<AudioDestinationNode> getDestination();
+    std::shared_ptr<GainNode> createGain();
 
     void install(jlong jsContext);
 
diff --git a/android/src/main/cpp/GainNode.cpp b/android/src/main/cpp/GainNode.cpp
new file mode 100644
index 00000000..2534ee6e
--- /dev/null
+++ b/android/src/main/cpp/GainNode.cpp
@@ -0,0 +1,16 @@
+#include "GainNode.h"
+
+namespace audiocontext{
+
+    using namespace facebook::jni;
+
+    double GainNode::getGain(){
+        static const auto method = javaClassLocal()->getMethod<jdouble()>("getGain");
+        return method(javaObject_.get());
+    }
+
+    void GainNode::setGain(double gain){
+        static const auto method = javaClassLocal()->getMethod<void(jdouble)>("setGain");
+        method(javaObject_.get(), gain);
+    }
+}
diff --git a/android/src/main/cpp/GainNode.h b/android/src/main/cpp/GainNode.h
new file mode 100644
index 00000000..cae8705d
--- /dev/null
+++ b/android/src/main/cpp/GainNode.h
@@ -0,0 +1,23 @@
+#pragma once
+
+#include <fbjni/fbjni.h>
+#include <react/jni/CxxModuleWrapper.h>
+#include <react/jni/JMessageQueueThread.h>
+#include <memory>
+#include "AudioNode.h"
+
+namespace audiocontext {
+
+    using namespace facebook;
+    using namespace facebook::jni;
+
+    class GainNode : public jni::HybridClass<GainNode, AudioNode> {
+    public:
+        static auto constexpr kJavaDescriptor = "Lcom/audiocontext/nodes/GainNode;";
+
+        double getGain();
+
+        void setGain(double gain);
+    };
+
+} // namespace audiocontext
diff --git a/android/src/main/java/com/audiocontext/context/AudioContext.kt b/android/src/main/java/com/audiocontext/context/AudioContext.kt
index e966e21f..8f289e51 100644
--- a/android/src/main/java/com/audiocontext/context/AudioContext.kt
+++ b/android/src/main/java/com/audiocontext/context/AudioContext.kt
@@ -1,6 +1,7 @@
 package com.audiocontext.context
 
 import com.audiocontext.nodes.AudioDestinationNode
+import com.audiocontext.nodes.GainNode
 import com.audiocontext.nodes.oscillator.OscillatorNode
 import com.facebook.jni.HybridData
 
@@ -27,4 +28,8 @@ class AudioContext() : BaseAudioContext {
   override fun createOscillator(): OscillatorNode {
     return OscillatorNode(this)
   }
+
+  override fun createGain(): GainNode {
+    return GainNode(this)
+  }
 }
diff --git a/android/src/main/java/com/audiocontext/context/BaseAudioContext.kt b/android/src/main/java/com/audiocontext/context/BaseAudioContext.kt
index eb5d124b..88d27e5d 100644
--- a/android/src/main/java/com/audiocontext/context/BaseAudioContext.kt
+++ b/android/src/main/java/com/audiocontext/context/BaseAudioContext.kt
@@ -1,6 +1,7 @@
 package com.audiocontext.context
 
 import com.audiocontext.nodes.AudioDestinationNode
+import com.audiocontext.nodes.GainNode
 import com.audiocontext.nodes.oscillator.OscillatorNode
 
 interface BaseAudioContext {
@@ -8,4 +9,5 @@ interface BaseAudioContext {
   val destination: AudioDestinationNode
 
   abstract fun createOscillator(): OscillatorNode
+  abstract fun createGain(): GainNode
 }
diff --git a/android/src/main/java/com/audiocontext/nodes/GainNode.kt b/android/src/main/java/com/audiocontext/nodes/GainNode.kt
new file mode 100644
index 00000000..c8312d32
--- /dev/null
+++ b/android/src/main/java/com/audiocontext/nodes/GainNode.kt
@@ -0,0 +1,22 @@
+package com.audiocontext.nodes
+
+import android.media.AudioTrack
+import com.audiocontext.context.BaseAudioContext
+import com.facebook.jni.HybridData
+
+class GainNode(context: BaseAudioContext): AudioNode(context) {
+  override val numberOfInputs: Int = 1
+  override val numberOfOutputs: Int = 1
+  private var gain: Double = 1.0
+    get() = field
+    set(value) {
+      field = value
+    }
+
+  private val mHybridData: HybridData? = initHybrid();
+
+  override fun process(buffer: ShortArray, audioTrack: AudioTrack) {
+    audioTrack.setVolume(gain.toFloat())
+    super.process(buffer, audioTrack)
+  }
+}
diff --git a/cpp/AudioContext/AudioContextHostObject.cpp b/cpp/AudioContext/AudioContextHostObject.cpp
index 8902b76a..d6f8550a 100644
--- a/cpp/AudioContext/AudioContextHostObject.cpp
+++ b/cpp/AudioContext/AudioContextHostObject.cpp
@@ -27,6 +27,14 @@ namespace audiocontext {
             return jsi::Object::createFromHostObject(runtime, destinationHostObject);
         }
 
+        if(propName == "createGain") {
+            return jsi::Function::createFromHostFunction(runtime, propNameId, 0, [this](jsi::Runtime& runtime, const jsi::Value& thisValue, const jsi::Value* arguments, size_t count) -> jsi::Value {
+                auto gain = wrapper_->createGain();
+                auto gainHostObject = GainNodeHostObject::createFromWrapper(gain);
+                return jsi::Object::createFromHostObject(runtime, gainHostObject);
+            });
+        }
+
         throw std::runtime_error("Not yet implemented!");
     }
 
diff --git a/cpp/AudioContext/AudioContextHostObject.h b/cpp/AudioContext/AudioContextHostObject.h
index bada6f7f..1876153a 100644
--- a/cpp/AudioContext/AudioContextHostObject.h
+++ b/cpp/AudioContext/AudioContextHostObject.h
@@ -6,6 +6,7 @@
 #include "AudioContextWrapper.h"
 #include "OscillatorNodeHostObject.h"
 #include "AudioDestinationNodeHostObject.h"
+#include "GainNodeHostObject.h"
 
 namespace audiocontext
 {
diff --git a/cpp/AudioContext/AudioContextWrapper.h b/cpp/AudioContext/AudioContextWrapper.h
index 09b9342e..e45edc59 100644
--- a/cpp/AudioContext/AudioContextWrapper.h
+++ b/cpp/AudioContext/AudioContextWrapper.h
@@ -4,6 +4,7 @@
 #include <utility>
 #include "OscillatorNodeWrapper.h"
 #include "AudioDestinationNodeWrapper.h"
+#include "GainNodeWrapper.h"
 
 #ifdef ANDROID
 #include "AudioContext.h"
@@ -34,5 +35,6 @@ namespace audiocontext {
 #endif
         std::shared_ptr<OscillatorNodeWrapper> createOscillator();
         std::shared_ptr<AudioDestinationNodeWrapper> getDestination();
+        std::shared_ptr<GainNodeWrapper> createGain();
     };
 } // namespace audiocontext
diff --git a/cpp/AudioContext/android/AudioContextWrapper.cpp b/cpp/AudioContext/android/AudioContextWrapper.cpp
index 9deb1c6c..1cb43962 100644
--- a/cpp/AudioContext/android/AudioContextWrapper.cpp
+++ b/cpp/AudioContext/android/AudioContextWrapper.cpp
@@ -11,4 +11,9 @@ namespace audiocontext {
         auto destination = audiocontext_->getDestination();
         return std::make_shared<AudioDestinationNodeWrapper>(destination);
     }
+
+    std::shared_ptr<GainNodeWrapper> AudioContextWrapper::createGain() {
+        auto gain = audiocontext_->createGain();
+        return std::make_shared<GainNodeWrapper>(gain);
+    }
 } // namespace audiocontext
diff --git a/cpp/GainNode/GainNodeHostObject.cpp b/cpp/GainNode/GainNodeHostObject.cpp
new file mode 100644
index 00000000..2b0b6945
--- /dev/null
+++ b/cpp/GainNode/GainNodeHostObject.cpp
@@ -0,0 +1,51 @@
+#include "GainNodeHostObject.h"
+
+namespace audiocontext
+{
+    using namespace facebook;
+
+    std::vector<jsi::PropNameID> GainNodeHostObject::getPropertyNames(jsi::Runtime &runtime)
+    {
+        std::vector<jsi::PropNameID> propertyNames;
+        propertyNames.push_back(jsi::PropNameID::forAscii(runtime, "gain"));
+        propertyNames.push_back(jsi::PropNameID::forAscii(runtime, "connect"));
+        return propertyNames;
+    }
+
+    jsi::Value GainNodeHostObject::get(jsi::Runtime &runtime, const jsi::PropNameID &propNameId)
+    {
+        auto propName = propNameId.utf8(runtime);
+
+        if (propName == "gain")
+        {
+            auto gain = wrapper_->getGain();
+            return jsi::Value(gain);
+        }
+
+        if (propName == "connect")
+        {
+            return jsi::Function::createFromHostFunction(runtime, propNameId, 1, [this](jsi::Runtime &rt, const jsi::Value &thisValue, const jsi::Value *args, size_t count) -> jsi::Value
+            {
+                auto node = args[0].getObject(rt).getHostObject<AudioNodeHostObject>(rt);
+                wrapper_->connect(std::shared_ptr<AudioNodeHostObject>(node)->wrapper_);
+                return jsi::Value::undefined();
+            });
+        }
+
+        throw std::runtime_error("Prop not yet implemented!");
+    }
+
+    void GainNodeHostObject::set(jsi::Runtime &runtime, const jsi::PropNameID &propNameId, const jsi::Value &value)
+    {
+        auto propName = propNameId.utf8(runtime);
+
+        if (propName == "gain")
+        {
+            double gain = value.getNumber();
+            wrapper_->setGain(gain);
+            return;
+        }
+
+        throw std::runtime_error("Not yet implemented!");
+    }
+}
diff --git a/cpp/GainNode/GainNodeHostObject.h b/cpp/GainNode/GainNodeHostObject.h
new file mode 100644
index 00000000..5463398b
--- /dev/null
+++ b/cpp/GainNode/GainNodeHostObject.h
@@ -0,0 +1,27 @@
+#pragma once
+
+#include <jsi/jsi.h>
+#include "GainNodeWrapper.h"
+#include "AudioNodeHostObject.h"
+
+namespace audiocontext {
+    using namespace facebook;
+
+    class GainNodeWrapper;
+
+    class GainNodeHostObject : public AudioNodeHostObject {
+    protected:
+        std::shared_ptr<GainNodeWrapper> wrapper_;
+
+    public:
+        explicit GainNodeHostObject(std::shared_ptr<GainNodeWrapper> wrapper) : AudioNodeHostObject(wrapper), wrapper_(wrapper) {}
+
+        jsi::Value get(jsi::Runtime& runtime, const jsi::PropNameID& name) override;
+        void set(jsi::Runtime& runtime, const jsi::PropNameID& name, const jsi::Value& value) override;
+        std::vector<jsi::PropNameID> getPropertyNames(jsi::Runtime& rt) override;
+
+        static std::shared_ptr<GainNodeHostObject> createFromWrapper(std::shared_ptr<GainNodeWrapper> wrapper) {
+            return std::make_shared<GainNodeHostObject>(wrapper);
+        }
+    };
+} // namespace audiocontext
diff --git a/cpp/GainNode/GainNodeWrapper.h b/cpp/GainNode/GainNodeWrapper.h
new file mode 100644
index 00000000..96918e33
--- /dev/null
+++ b/cpp/GainNode/GainNodeWrapper.h
@@ -0,0 +1,33 @@
+#pragma once
+
+#include <memory>
+#include "AudioNodeWrapper.h"
+
+#ifdef ANDROID
+#include "GainNode.h"
+#endif
+
+namespace audiocontext {
+    using namespace facebook;
+
+#ifdef ANDROID
+    class GainNode;
+#endif
+
+    class GainNodeWrapper: public AudioNodeWrapper {
+#ifdef ANDROID
+    private:
+        std::shared_ptr<GainNode> gain_;
+#endif
+
+    public:
+#ifdef ANDROID
+        explicit GainNodeWrapper( std::shared_ptr<GainNode> gain) : AudioNodeWrapper(
+                gain), gain_(gain) {}
+#else
+        explicit GainNodeWrapper() {}
+#endif
+        double getGain();
+        void setGain(double gain);
+    };
+} // namespace audiocontext
diff --git a/cpp/GainNode/android/GainNodeWrapper.cpp b/cpp/GainNode/android/GainNodeWrapper.cpp
new file mode 100644
index 00000000..7e99b5e6
--- /dev/null
+++ b/cpp/GainNode/android/GainNodeWrapper.cpp
@@ -0,0 +1,12 @@
+#include "GainNodeWrapper.h"
+
+namespace audiocontext {
+
+    double GainNodeWrapper::getGain() {
+        return gain_->getGain();
+    }
+
+    void GainNodeWrapper::setGain(double gain) {
+        gain_->setGain(gain);
+    }
+}
diff --git a/cpp/GainNode/ios/.keep b/cpp/GainNode/ios/.keep
new file mode 100644
index 00000000..e69de29b
diff --git a/example/src/App.tsx b/example/src/App.tsx
index 082ff811..2b39185f 100644
--- a/example/src/App.tsx
+++ b/example/src/App.tsx
@@ -1,26 +1,33 @@
 /* eslint-disable react/react-in-jsx-scope */
 import { Button, StyleSheet, Text, View } from 'react-native';
-import { useRef, useEffect } from 'react';
+import { useRef, useState, useEffect } from 'react';
 
-import { AudioContext, type Oscillator } from 'react-native-audio-context';
+import {
+  AudioContext,
+  type Oscillator,
+  type Gain,
+} from 'react-native-audio-context';
 
 const App = () => {
+  const [isPlaying, setIsPlaying] = useState(false);
+
   const audioContextRef = useRef<AudioContext | null>(null);
   const oscillatorRef = useRef<Oscillator | null>(null);
-  const secondaryOscillatorRef = useRef<Oscillator | null>(null);
+  const gainRef = useRef<Gain | null>(null);
 
   const setUp = () => {
     audioContextRef.current = new AudioContext();
+
     oscillatorRef.current = audioContextRef.current.createOscillator();
     oscillatorRef.current.frequency = 800;
+    oscillatorRef.current.type = 'sine';
 
-    secondaryOscillatorRef.current = audioContextRef.current.createOscillator();
-    secondaryOscillatorRef.current.frequency = 300;
-    secondaryOscillatorRef.current.type = 'square';
+    gainRef.current = audioContextRef.current.createGain();
+    gainRef.current.gain = 1.0;
 
     const destination = audioContextRef.current.destination;
-    oscillatorRef.current.connect(destination);
-    secondaryOscillatorRef.current.connect(destination);
+    oscillatorRef.current.connect(gainRef.current);
+    gainRef.current.connect(destination);
   };
 
   useEffect(() => {
@@ -29,27 +36,24 @@ const App = () => {
     };
   }, []);
 
-  const startOscillator = () => {
+  const handlePlayPause = () => {
     if (!audioContextRef.current) {
       setUp();
     }
 
-    oscillatorRef.current?.start(1);
-    secondaryOscillatorRef.current?.start(0);
-  };
-  const stopOscillator = () => {
-    if (!audioContextRef.current) {
-      setUp();
+    if (isPlaying) {
+      oscillatorRef.current?.stop(0);
+    } else {
+      oscillatorRef.current?.start(0);
     }
-    oscillatorRef.current?.stop(0);
-    secondaryOscillatorRef.current?.stop(0);
+
+    setIsPlaying(!isPlaying);
   };
 
   return (
     <View style={styles.container}>
       <Text style={styles.title}>React Native Oscillator</Text>
-      <Button title="Start Oscillator" onPress={startOscillator} />
-      <Button title="Stop Oscillator" onPress={stopOscillator} />
+      <Button title={isPlaying ? 'Pause' : 'Play'} onPress={handlePlayPause} />
     </View>
   );
 };
diff --git a/src/index.ts b/src/index.ts
index 30d43071..c6ddf66b 100644
--- a/src/index.ts
+++ b/src/index.ts
@@ -4,6 +4,7 @@ import type {
   Oscillator,
   BaseAudioContext,
   AudioDestinationNode,
+  Gain,
 } from './types';
 
 declare global {
@@ -22,6 +23,10 @@ export class AudioContext implements BaseAudioContext {
   createOscillator(): Oscillator {
     return global.__AudioContext.createOscillator();
   }
+
+  createGain(): Gain {
+    return global.__AudioContext.createGain();
+  }
 }
 
-export type { Oscillator };
+export type { Oscillator, Gain };
diff --git a/src/types.ts b/src/types.ts
index 2301da63..58790a68 100644
--- a/src/types.ts
+++ b/src/types.ts
@@ -1,6 +1,7 @@
 export interface BaseAudioContext {
   destination: AudioDestinationNode;
   createOscillator(): Oscillator;
+  createGain(): Gain;
 }
 
 export interface AudioNode {
@@ -23,3 +24,7 @@ export interface Oscillator extends AudioScheduledSourceNode {
   type: WaveType;
   detune: number;
 }
+
+export interface Gain extends AudioNode {
+  gain: number;
+}

From 7403fad59f4836c6a889b0984fe5f4264c43f212 Mon Sep 17 00:00:00 2001
From: Maciej Makowski <maciej.makowski@swmansion.com>
Date: Tue, 23 Jul 2024 11:25:23 +0200
Subject: [PATCH 2/7] refactor: imports refactoring

---
 android/src/main/cpp/AudioDestinationNode.cpp               | 6 ------
 android/src/main/cpp/AudioDestinationNode.h                 | 4 +---
 .../java/com/audiocontext/nodes/AudioDestinationNode.kt     | 2 --
 3 files changed, 1 insertion(+), 11 deletions(-)

diff --git a/android/src/main/cpp/AudioDestinationNode.cpp b/android/src/main/cpp/AudioDestinationNode.cpp
index cef18fb4..b89481a4 100644
--- a/android/src/main/cpp/AudioDestinationNode.cpp
+++ b/android/src/main/cpp/AudioDestinationNode.cpp
@@ -1,7 +1 @@
 #include "AudioDestinationNode.h"
-
-namespace audiocontext {
-
-    using namespace facebook::jni;
-
-} // namespace audiocontext
diff --git a/android/src/main/cpp/AudioDestinationNode.h b/android/src/main/cpp/AudioDestinationNode.h
index b7526d53..155eaa65 100644
--- a/android/src/main/cpp/AudioDestinationNode.h
+++ b/android/src/main/cpp/AudioDestinationNode.h
@@ -4,15 +4,13 @@
 #include <react/jni/CxxModuleWrapper.h>
 #include <react/jni/JMessageQueueThread.h>
 #include <memory>
-#include "OscillatorNode.h"
+#include "AudioNode.h"
 
 namespace audiocontext {
 
     using namespace facebook;
     using namespace facebook::jni;
 
-    class OscillatorNode;
-
     class AudioDestinationNode : public jni::HybridClass<AudioDestinationNode, AudioNode> {
     public:
         static auto constexpr kJavaDescriptor = "Lcom/audiocontext/nodes/AudioDestinationNode;";
diff --git a/android/src/main/java/com/audiocontext/nodes/AudioDestinationNode.kt b/android/src/main/java/com/audiocontext/nodes/AudioDestinationNode.kt
index e9da01a6..9562cbdc 100644
--- a/android/src/main/java/com/audiocontext/nodes/AudioDestinationNode.kt
+++ b/android/src/main/java/com/audiocontext/nodes/AudioDestinationNode.kt
@@ -1,10 +1,8 @@
 package com.audiocontext.nodes
 
 import android.media.AudioTrack
-import android.util.Log
 import com.audiocontext.context.BaseAudioContext
 import com.facebook.jni.HybridData
-import com.facebook.react.bridge.ReactApplicationContext
 
 
 class AudioDestinationNode(context: BaseAudioContext): AudioNode(context) {

From 9323b5fb9a31a9e4f69e189cc5669a47d7543d59 Mon Sep 17 00:00:00 2001
From: Maciej Makowski <maciej.makowski@swmansion.com>
Date: Wed, 24 Jul 2024 12:54:05 +0200
Subject: [PATCH 3/7] feat: implemented silders for changing volume, frequency
 and detune

---
 example/package.json |  1 +
 example/src/App.tsx  | 95 ++++++++++++++++++++++++++++++++++++++++----
 yarn.lock            | 11 +++++
 3 files changed, 100 insertions(+), 7 deletions(-)

diff --git a/example/package.json b/example/package.json
index 5d775135..8547404c 100644
--- a/example/package.json
+++ b/example/package.json
@@ -10,6 +10,7 @@
     "build:ios": "react-native build-ios --scheme AudioContextExample --mode Debug --extra-params \"-sdk iphonesimulator CC=clang CPLUSPLUS=clang++ LD=clang LDPLUSPLUS=clang++ GCC_OPTIMIZATION_LEVEL=0 GCC_PRECOMPILE_PREFIX_HEADER=YES ASSETCATALOG_COMPILER_OPTIMIZATION=time DEBUG_INFORMATION_FORMAT=dwarf COMPILER_INDEX_STORE_ENABLE=NO\""
   },
   "dependencies": {
+    "@miblanchard/react-native-slider": "^2.6.0",
     "react": "18.2.0",
     "react-native": "0.74.3"
   },
diff --git a/example/src/App.tsx b/example/src/App.tsx
index 2b39185f..34dbe288 100644
--- a/example/src/App.tsx
+++ b/example/src/App.tsx
@@ -1,6 +1,7 @@
 /* eslint-disable react/react-in-jsx-scope */
 import { Button, StyleSheet, Text, View } from 'react-native';
 import { useRef, useState, useEffect } from 'react';
+import { Slider } from '@miblanchard/react-native-slider';
 
 import {
   AudioContext,
@@ -9,7 +10,10 @@ import {
 } from 'react-native-audio-context';
 
 const App = () => {
-  const [isPlaying, setIsPlaying] = useState(false);
+  const [isPlaying, setIsPlaying] = useState<boolean>(false);
+  const [gain, setGain] = useState<number>(1.0);
+  const [frequency, setFrequency] = useState<number>(440);
+  const [detune, setDetune] = useState<number>(0);
 
   const audioContextRef = useRef<AudioContext | null>(null);
   const oscillatorRef = useRef<Oscillator | null>(null);
@@ -19,20 +23,35 @@ const App = () => {
     audioContextRef.current = new AudioContext();
 
     oscillatorRef.current = audioContextRef.current.createOscillator();
-    oscillatorRef.current.frequency = 800;
+    oscillatorRef.current.frequency = frequency;
+    oscillatorRef.current.detune = detune;
     oscillatorRef.current.type = 'sine';
 
     gainRef.current = audioContextRef.current.createGain();
-    gainRef.current.gain = 1.0;
+    gainRef.current.gain = gain;
 
     const destination = audioContextRef.current.destination;
     oscillatorRef.current.connect(gainRef.current);
     gainRef.current.connect(destination);
   };
 
+  const handleSliderChange = (
+    value: number[],
+    defaultValue: number,
+    setValue: (value: number) => void,
+    ref: React.MutableRefObject<{ [key: string]: any } | null>,
+    propName: string
+  ) => {
+    const newValue = value[0] || defaultValue;
+    setValue(newValue);
+    if (ref.current) {
+      ref.current[propName] = newValue;
+    }
+  };
+
   useEffect(() => {
     return () => {
-      //TODO
+      oscillatorRef.current?.stop(0);
     };
   }, []);
 
@@ -51,25 +70,87 @@ const App = () => {
   };
 
   return (
-    <View style={styles.container}>
+    <View style={styles.mainContainer}>
       <Text style={styles.title}>React Native Oscillator</Text>
-      <Button title={isPlaying ? 'Pause' : 'Play'} onPress={handlePlayPause} />
+      <View style={styles.button}>
+        <Button
+          title={isPlaying ? 'Pause' : 'Play'}
+          onPress={handlePlayPause}
+        />
+      </View>
+      <View style={styles.container}>
+        <Text>Gain: {gain.toFixed(1)}</Text>
+        <Slider
+          containerStyle={styles.slider}
+          value={gain}
+          onValueChange={(value) =>
+            handleSliderChange(value, 0.0, setGain, gainRef, 'gain')
+          }
+          minimumValue={0.0}
+          maximumValue={1.0}
+          step={0.1}
+        />
+      </View>
+      <View style={styles.container}>
+        <Text>Frequency: {frequency.toFixed(0)}</Text>
+        <Slider
+          containerStyle={styles.slider}
+          value={frequency}
+          onValueChange={(value) =>
+            handleSliderChange(
+              value,
+              440,
+              setFrequency,
+              oscillatorRef,
+              'frequency'
+            )
+          }
+          minimumValue={120}
+          maximumValue={1200}
+          step={10}
+        />
+      </View>
+      <View style={styles.container}>
+        <Text>Detune: {detune.toFixed(0)}</Text>
+        <Slider
+          containerStyle={styles.slider}
+          value={detune}
+          onValueChange={(value) =>
+            handleSliderChange(value, 0, setDetune, oscillatorRef, 'detune')
+          }
+          minimumValue={0}
+          maximumValue={100}
+          step={1}
+        />
+      </View>
     </View>
   );
 };
 
 const styles = StyleSheet.create({
-  container: {
+  mainContainer: {
     flex: 1,
     justifyContent: 'center',
     alignItems: 'center',
     backgroundColor: '#F5FCFF',
   },
+  container: {
+    justifyContent: 'center',
+    alignItems: 'center',
+    margin: 10,
+  },
   title: {
     fontSize: 20,
     textAlign: 'center',
     margin: 10,
   },
+  button: {
+    width: 100,
+  },
+  slider: {
+    width: 300,
+    padding: 10,
+  },
 });
 
 export default App;
diff --git a/yarn.lock b/yarn.lock
index ce070645..f758ea18 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -2369,6 +2369,16 @@ __metadata:
   languageName: node
   linkType: hard
 
+"@miblanchard/react-native-slider@npm:^2.6.0":
+  version: 2.6.0
+  resolution: "@miblanchard/react-native-slider@npm:2.6.0"
+  peerDependencies:
+    react: ">=16.8"
+    react-native: ">=0.59"
+  checksum: cdaaca314e94133e87a623cfe59dac950aeb6ba09946fb89f03d4c2a0cd131db80b368c320c34e5c126a10041026a83e00df3182d2346857e7b51aed96632748
+  languageName: node
+  linkType: hard
+
 "@nicolo-ribaudo/eslint-scope-5-internals@npm:5.1.1-v1":
   version: 5.1.1-v1
   resolution: "@nicolo-ribaudo/eslint-scope-5-internals@npm:5.1.1-v1"
@@ -10862,6 +10872,7 @@ __metadata:
     "@babel/core": ^7.20.0
     "@babel/preset-env": ^7.20.0
     "@babel/runtime": ^7.20.0
+    "@miblanchard/react-native-slider": ^2.6.0
     "@react-native/babel-preset": 0.74.85
     "@react-native/metro-config": 0.74.85
     "@react-native/typescript-config": 0.74.85

From 1e61c132fce77543e825afee086630159cdb7450 Mon Sep 17 00:00:00 2001
From: Maciej Makowski <maciej.makowski@swmansion.com>
Date: Wed, 24 Jul 2024 13:09:45 +0200
Subject: [PATCH 4/7] refactor: added get methods to AudioNodeHostObject,
 refactored derived classes

---
 android/CMakeLists.txt                        |  2 +-
 cpp/AudioContext/AudioContextHostObject.h     |  4 +-
 cpp/AudioContext/AudioContextWrapper.h        |  2 +-
 .../AudioDestinationNodeHostObject.h          |  5 +--
 .../AudioDestinationNodeWrapper.h             |  9 ++--
 cpp/AudioNode/AudioNodeHostObject.cpp         | 45 +++++++++++++++++++
 cpp/AudioNode/AudioNodeHostObject.h           |  8 +++-
 cpp/AudioNode/AudioNodeWrapper.h              | 12 ++---
 cpp/AudioNode/android/AudioNodeWrapper.cpp    |  4 +-
 cpp/GainNode/GainNodeHostObject.cpp           | 15 +------
 cpp/GainNode/GainNodeHostObject.h             |  4 +-
 cpp/GainNode/GainNodeWrapper.h                |  6 +--
 .../OscillatorNodeHostObject.cpp              | 15 +------
 cpp/OscillatorNode/OscillatorNodeHostObject.h |  4 +-
 cpp/OscillatorNode/OscillatorNodeWrapper.h    |  9 ++--
 15 files changed, 82 insertions(+), 62 deletions(-)
 create mode 100644 cpp/AudioNode/AudioNodeHostObject.cpp

diff --git a/android/CMakeLists.txt b/android/CMakeLists.txt
index 2ba14671..b1c84c22 100644
--- a/android/CMakeLists.txt
+++ b/android/CMakeLists.txt
@@ -44,7 +44,7 @@ add_library(react-native-audio-context SHARED
         ../cpp/OscillatorNode/OscillatorNodeWrapper.h
         ../cpp/OscillatorNode/android/OscillatorNodeWrapper.cpp
 
-        ../cpp/AudioNode/AudioNodeHostObject.h
+        ../cpp/AudioNode/AudioNodeHostObject
         ../cpp/AudioNode/AudioNodeWrapper.h
         ../cpp/AudioNode/android/AudioNodeWrapper.cpp
 
diff --git a/cpp/AudioContext/AudioContextHostObject.h b/cpp/AudioContext/AudioContextHostObject.h
index 1876153a..58fcc230 100644
--- a/cpp/AudioContext/AudioContextHostObject.h
+++ b/cpp/AudioContext/AudioContextHostObject.h
@@ -20,9 +20,9 @@ namespace audiocontext
         std::shared_ptr<AudioContextWrapper> wrapper_;
 
     public:
-        explicit AudioContextHostObject(std::shared_ptr<AudioContextWrapper> wrapper) : wrapper_(wrapper) {}
+        explicit AudioContextHostObject(const std::shared_ptr<AudioContextWrapper> &wrapper) : wrapper_(wrapper) {}
 
-        static void createAndInstallFromWrapper(const std::shared_ptr<AudioContextWrapper>& wrapper, jlong jsContext) {
+        static void createAndInstallFromWrapper(const std::shared_ptr<AudioContextWrapper> &wrapper, jlong jsContext) {
             auto runtime = reinterpret_cast<jsi::Runtime *>(jsContext);
             auto hostObject = std::make_shared<AudioContextHostObject>(wrapper);
             auto object = jsi::Object::createFromHostObject(*runtime, hostObject);
diff --git a/cpp/AudioContext/AudioContextWrapper.h b/cpp/AudioContext/AudioContextWrapper.h
index e45edc59..6fb5210d 100644
--- a/cpp/AudioContext/AudioContextWrapper.h
+++ b/cpp/AudioContext/AudioContextWrapper.h
@@ -29,7 +29,7 @@ namespace audiocontext {
     public:
 #ifdef ANDROID
         explicit AudioContextWrapper(
-                std::shared_ptr<AudioContext> audiocontext) : audiocontext_(audiocontext) {}
+                const std::shared_ptr<AudioContext> &audiocontext) : audiocontext_(audiocontext) {}
 #else
         explicit AudioContextWrapper() {}
 #endif
diff --git a/cpp/AudioDestinationNode/AudioDestinationNodeHostObject.h b/cpp/AudioDestinationNode/AudioDestinationNodeHostObject.h
index 1f56395a..aa0da347 100644
--- a/cpp/AudioDestinationNode/AudioDestinationNodeHostObject.h
+++ b/cpp/AudioDestinationNode/AudioDestinationNodeHostObject.h
@@ -8,7 +8,6 @@ namespace audiocontext {
     using namespace facebook;
 
     class AudioDestinationNodeWrapper;
-    class OscillatorNodeWrapper;
 
     class AudioDestinationNodeHostObject : public AudioNodeHostObject {
 
@@ -16,13 +15,13 @@ namespace audiocontext {
         std::shared_ptr<AudioDestinationNodeWrapper> wrapper_;
 
     public:
-        explicit AudioDestinationNodeHostObject(std::shared_ptr<AudioDestinationNodeWrapper> wrapper): AudioNodeHostObject(wrapper), wrapper_(wrapper) {}
+        explicit AudioDestinationNodeHostObject(const std::shared_ptr<AudioDestinationNodeWrapper> &wrapper): AudioNodeHostObject(wrapper), wrapper_(wrapper) {}
 
         jsi::Value get(jsi::Runtime& runtime, const jsi::PropNameID& name) override;
         void set(jsi::Runtime& runtime, const jsi::PropNameID& name, const jsi::Value& value) override;
         std::vector<jsi::PropNameID> getPropertyNames(jsi::Runtime& rt) override;
 
-        static std::shared_ptr<AudioDestinationNodeHostObject> createFromWrapper(std::shared_ptr<AudioDestinationNodeWrapper> wrapper) {
+        static std::shared_ptr<AudioDestinationNodeHostObject> createFromWrapper(const std::shared_ptr<AudioDestinationNodeWrapper> &wrapper) {
             return std::make_shared<AudioDestinationNodeHostObject>(wrapper);
         }
     };
diff --git a/cpp/AudioDestinationNode/AudioDestinationNodeWrapper.h b/cpp/AudioDestinationNode/AudioDestinationNodeWrapper.h
index e81e4152..333e4d87 100644
--- a/cpp/AudioDestinationNode/AudioDestinationNodeWrapper.h
+++ b/cpp/AudioDestinationNode/AudioDestinationNodeWrapper.h
@@ -4,7 +4,7 @@
 
 #ifdef ANDROID
 #include "AudioDestinationNode.h"
-#include "OscillatorNodeWrapper.h"
+#include "AudioNodeWrapper.h"
 #endif
 
 namespace audiocontext {
@@ -17,15 +17,12 @@ namespace audiocontext {
     class AudioDestinationNodeWrapper: public AudioNodeWrapper {
 #ifdef ANDROID
     private:
-        friend class OscillatorNodeWrapper;
-
         std::shared_ptr<AudioDestinationNode> destination_;
-#endif
 
     public:
-#ifdef ANDROID
-        explicit AudioDestinationNodeWrapper(std::shared_ptr<AudioDestinationNode> destination) : AudioNodeWrapper(destination), destination_(destination) {}
+        explicit AudioDestinationNodeWrapper(const std::shared_ptr<AudioDestinationNode> &destination) : AudioNodeWrapper(destination), destination_(destination) {}
 #else
+    public:
         explicit AudioDestinationNodeWrapper() {}
 #endif
     };
diff --git a/cpp/AudioNode/AudioNodeHostObject.cpp b/cpp/AudioNode/AudioNodeHostObject.cpp
new file mode 100644
index 00000000..3912ec8b
--- /dev/null
+++ b/cpp/AudioNode/AudioNodeHostObject.cpp
@@ -0,0 +1,45 @@
+#include "AudioNodeHostObject.h"
+
+namespace audiocontext {
+    using namespace facebook;
+
+    std::vector<jsi::PropNameID> AudioNodeHostObject::getPropertyNames(jsi::Runtime& runtime) {
+        std::vector<jsi::PropNameID> propertyNames;
+        propertyNames.push_back(jsi::PropNameID::forAscii(runtime, "connect"));
+        propertyNames.push_back(jsi::PropNameID::forAscii(runtime, "disconnect"));
+        return propertyNames;
+    }
+
+    jsi::Value AudioNodeHostObject::get(jsi::Runtime& runtime, const jsi::PropNameID& propNameId) {
+        auto propName = propNameId.utf8(runtime);
+
+        if (propName == "connect")
+        {
+            return jsi::Function::createFromHostFunction(runtime, propNameId, 1, [this](jsi::Runtime &rt, const jsi::Value &thisValue, const jsi::Value *args, size_t count) -> jsi::Value
+            {
+                auto node = args[0].getObject(rt).getHostObject<AudioNodeHostObject>(rt);
+                wrapper_->connect(std::shared_ptr<AudioNodeHostObject>(node)->wrapper_);
+                return jsi::Value::undefined();
+            });
+        }
+
+        if (propName == "disconnect")
+        {
+            return jsi::Function::createFromHostFunction(runtime, propNameId, 1, [this](jsi::Runtime &rt, const jsi::Value &thisValue, const jsi::Value *args, size_t count) -> jsi::Value
+            {
+                auto node = args[0].getObject(rt).getHostObject<AudioNodeHostObject>(rt);
+                wrapper_->disconnect(std::shared_ptr<AudioNodeHostObject>(node)->wrapper_);
+                return jsi::Value::undefined();
+            });
+        }
+
+        throw std::runtime_error("Not yet implemented!");
+    }
+
+    void AudioNodeHostObject::set(jsi::Runtime& runtime, const jsi::PropNameID& propNameId, const jsi::Value& value) {
+        auto propName = propNameId.utf8(runtime);
+
+        throw std::runtime_error("Not yet implemented!");
+    }
+
+}
diff --git a/cpp/AudioNode/AudioNodeHostObject.h b/cpp/AudioNode/AudioNodeHostObject.h
index ef3badef..23794309 100644
--- a/cpp/AudioNode/AudioNodeHostObject.h
+++ b/cpp/AudioNode/AudioNodeHostObject.h
@@ -10,10 +10,14 @@ namespace audiocontext {
 
     class AudioNodeHostObject : public jsi::HostObject {
 
-    public:
+    protected:
         std::shared_ptr<AudioNodeWrapper> wrapper_;
 
     public:
-        explicit AudioNodeHostObject(std::shared_ptr<AudioNodeWrapper> wrapper) : wrapper_(wrapper) {}
+        explicit AudioNodeHostObject(const std::shared_ptr<AudioNodeWrapper> &wrapper) : wrapper_(wrapper) {}
+
+        jsi::Value get(jsi::Runtime& runtime, const jsi::PropNameID& name) override;
+        void set(jsi::Runtime& runtime, const jsi::PropNameID& name, const jsi::Value& value) override;
+        std::vector<jsi::PropNameID> getPropertyNames(jsi::Runtime& rt) override;
     };
 } // namespace audiocontext
diff --git a/cpp/AudioNode/AudioNodeWrapper.h b/cpp/AudioNode/AudioNodeWrapper.h
index 1de3b5b2..2ffa7375 100644
--- a/cpp/AudioNode/AudioNodeWrapper.h
+++ b/cpp/AudioNode/AudioNodeWrapper.h
@@ -10,15 +10,17 @@ namespace audiocontext {
     using namespace facebook;
 
     class AudioNodeWrapper {
-    public:
 #ifdef ANDROID
+    protected:
         std::shared_ptr<AudioNode> node_;
-
-        explicit AudioNodeWrapper(std::shared_ptr<AudioNode> node) : node_(node) {}
+    public:
+        explicit AudioNodeWrapper(const std::shared_ptr<AudioNode> &node) : node_(node) {}
 #else
+    public:
         explicit AudioNodeWrapper() {}
 #endif
-        void connect(const std::shared_ptr<AudioNodeWrapper> node) const;
-        void disconnect(const std::shared_ptr<AudioNodeWrapper> node) const;
+    public:
+        void connect(const std::shared_ptr<AudioNodeWrapper> &node) const;
+        void disconnect(const std::shared_ptr<AudioNodeWrapper> &node) const;
     };
 } // namespace audiocontext
diff --git a/cpp/AudioNode/android/AudioNodeWrapper.cpp b/cpp/AudioNode/android/AudioNodeWrapper.cpp
index 59fea09f..ef4c7338 100644
--- a/cpp/AudioNode/android/AudioNodeWrapper.cpp
+++ b/cpp/AudioNode/android/AudioNodeWrapper.cpp
@@ -2,11 +2,11 @@
 
 namespace audiocontext {
 
-    void AudioNodeWrapper::connect(const std::shared_ptr<AudioNodeWrapper> node) const {
+    void AudioNodeWrapper::connect(const std::shared_ptr<AudioNodeWrapper> &node) const {
         node_->connect(node->node_);
    }
 
-    void AudioNodeWrapper::disconnect(const std::shared_ptr<AudioNodeWrapper> node) const {
+    void AudioNodeWrapper::disconnect(const std::shared_ptr<AudioNodeWrapper> &node) const {
         node_->disconnect(node->node_);
     }
 }
diff --git a/cpp/GainNode/GainNodeHostObject.cpp b/cpp/GainNode/GainNodeHostObject.cpp
index 2b0b6945..7b60e3e3 100644
--- a/cpp/GainNode/GainNodeHostObject.cpp
+++ b/cpp/GainNode/GainNodeHostObject.cpp
@@ -6,9 +6,8 @@ namespace audiocontext
 
     std::vector<jsi::PropNameID> GainNodeHostObject::getPropertyNames(jsi::Runtime &runtime)
     {
-        std::vector<jsi::PropNameID> propertyNames;
+        std::vector<jsi::PropNameID> propertyNames = AudioNodeHostObject::getPropertyNames(runtime);
         propertyNames.push_back(jsi::PropNameID::forAscii(runtime, "gain"));
-        propertyNames.push_back(jsi::PropNameID::forAscii(runtime, "connect"));
         return propertyNames;
     }
 
@@ -22,17 +21,7 @@ namespace audiocontext
             return jsi::Value(gain);
         }
 
-        if (propName == "connect")
-        {
-            return jsi::Function::createFromHostFunction(runtime, propNameId, 1, [this](jsi::Runtime &rt, const jsi::Value &thisValue, const jsi::Value *args, size_t count) -> jsi::Value
-            {
-                auto node = args[0].getObject(rt).getHostObject<AudioNodeHostObject>(rt);
-                wrapper_->connect(std::shared_ptr<AudioNodeHostObject>(node)->wrapper_);
-                return jsi::Value::undefined();
-            });
-        }
-
-        throw std::runtime_error("Prop not yet implemented!");
+        return AudioNodeHostObject::get(runtime, propNameId);
     }
 
     void GainNodeHostObject::set(jsi::Runtime &runtime, const jsi::PropNameID &propNameId, const jsi::Value &value)
diff --git a/cpp/GainNode/GainNodeHostObject.h b/cpp/GainNode/GainNodeHostObject.h
index 5463398b..957a34d9 100644
--- a/cpp/GainNode/GainNodeHostObject.h
+++ b/cpp/GainNode/GainNodeHostObject.h
@@ -14,13 +14,13 @@ namespace audiocontext {
         std::shared_ptr<GainNodeWrapper> wrapper_;
 
     public:
-        explicit GainNodeHostObject(std::shared_ptr<GainNodeWrapper> wrapper) : AudioNodeHostObject(wrapper), wrapper_(wrapper) {}
+        explicit GainNodeHostObject(const std::shared_ptr<GainNodeWrapper> &wrapper) : AudioNodeHostObject(wrapper), wrapper_(wrapper) {}
 
         jsi::Value get(jsi::Runtime& runtime, const jsi::PropNameID& name) override;
         void set(jsi::Runtime& runtime, const jsi::PropNameID& name, const jsi::Value& value) override;
         std::vector<jsi::PropNameID> getPropertyNames(jsi::Runtime& rt) override;
 
-        static std::shared_ptr<GainNodeHostObject> createFromWrapper(std::shared_ptr<GainNodeWrapper> wrapper) {
+        static std::shared_ptr<GainNodeHostObject> createFromWrapper(const std::shared_ptr<GainNodeWrapper> &wrapper) {
             return std::make_shared<GainNodeHostObject>(wrapper);
         }
     };
diff --git a/cpp/GainNode/GainNodeWrapper.h b/cpp/GainNode/GainNodeWrapper.h
index 96918e33..94f0a774 100644
--- a/cpp/GainNode/GainNodeWrapper.h
+++ b/cpp/GainNode/GainNodeWrapper.h
@@ -18,13 +18,11 @@ namespace audiocontext {
 #ifdef ANDROID
     private:
         std::shared_ptr<GainNode> gain_;
-#endif
-
     public:
-#ifdef ANDROID
-        explicit GainNodeWrapper( std::shared_ptr<GainNode> gain) : AudioNodeWrapper(
+        explicit GainNodeWrapper(const std::shared_ptr<GainNode> &gain) : AudioNodeWrapper(
                 gain), gain_(gain) {}
 #else
+    public:
         explicit GainNodeWrapper() {}
 #endif
         double getGain();
diff --git a/cpp/OscillatorNode/OscillatorNodeHostObject.cpp b/cpp/OscillatorNode/OscillatorNodeHostObject.cpp
index 2ae3619e..22cfad4f 100644
--- a/cpp/OscillatorNode/OscillatorNodeHostObject.cpp
+++ b/cpp/OscillatorNode/OscillatorNodeHostObject.cpp
@@ -6,13 +6,12 @@ namespace audiocontext
 
   std::vector<jsi::PropNameID> OscillatorNodeHostObject::getPropertyNames(jsi::Runtime &runtime)
   {
-    std::vector<jsi::PropNameID> propertyNames;
+    std::vector<jsi::PropNameID> propertyNames = AudioNodeHostObject::getPropertyNames(runtime);
     propertyNames.push_back(jsi::PropNameID::forAscii(runtime, "start"));
     propertyNames.push_back(jsi::PropNameID::forAscii(runtime, "stop"));
     propertyNames.push_back(jsi::PropNameID::forAscii(runtime, "frequency"));
     propertyNames.push_back(jsi::PropNameID::forAscii(runtime, "detune"));
     propertyNames.push_back(jsi::PropNameID::forAscii(runtime, "type"));
-    propertyNames.push_back(jsi::PropNameID::forAscii(runtime, "connect"));
     return propertyNames;
   }
 
@@ -58,17 +57,7 @@ namespace audiocontext
         return jsi::String::createFromUtf8(runtime, waveType);
     }
 
-    if (propName == "connect")
-    {
-        return jsi::Function::createFromHostFunction(runtime, propNameId, 1, [this](jsi::Runtime &rt, const jsi::Value &thisValue, const jsi::Value *args, size_t count) -> jsi::Value
-        {
-            auto node = args[0].getObject(rt).getHostObject<AudioNodeHostObject>(rt);
-            wrapper_->connect(std::shared_ptr<AudioNodeHostObject>(node)->wrapper_);
-            return jsi::Value::undefined();
-        });
-    }
-
-    throw std::runtime_error("Prop not yet implemented!");
+    return AudioNodeHostObject::get(runtime, propNameId);
   }
 
   void OscillatorNodeHostObject::set(jsi::Runtime &runtime, const jsi::PropNameID &propNameId, const jsi::Value &value)
diff --git a/cpp/OscillatorNode/OscillatorNodeHostObject.h b/cpp/OscillatorNode/OscillatorNodeHostObject.h
index c9fbb284..8640a984 100644
--- a/cpp/OscillatorNode/OscillatorNodeHostObject.h
+++ b/cpp/OscillatorNode/OscillatorNodeHostObject.h
@@ -14,13 +14,13 @@ namespace audiocontext {
         std::shared_ptr<OscillatorNodeWrapper> wrapper_;
 
     public:
-        explicit OscillatorNodeHostObject(std::shared_ptr<OscillatorNodeWrapper> wrapper) : AudioNodeHostObject(wrapper), wrapper_(wrapper) {}
+        explicit OscillatorNodeHostObject(const std::shared_ptr<OscillatorNodeWrapper> &wrapper) : AudioNodeHostObject(wrapper), wrapper_(wrapper) {}
 
         jsi::Value get(jsi::Runtime& runtime, const jsi::PropNameID& name) override;
         void set(jsi::Runtime& runtime, const jsi::PropNameID& name, const jsi::Value& value) override;
         std::vector<jsi::PropNameID> getPropertyNames(jsi::Runtime& rt) override;
 
-        static std::shared_ptr<OscillatorNodeHostObject> createFromWrapper(std::shared_ptr<OscillatorNodeWrapper> wrapper) {
+        static std::shared_ptr<OscillatorNodeHostObject> createFromWrapper(const std::shared_ptr<OscillatorNodeWrapper> &wrapper) {
             return std::make_shared<OscillatorNodeHostObject>(wrapper);
         }
     };
diff --git a/cpp/OscillatorNode/OscillatorNodeWrapper.h b/cpp/OscillatorNode/OscillatorNodeWrapper.h
index 8bf41042..98efe10e 100644
--- a/cpp/OscillatorNode/OscillatorNodeWrapper.h
+++ b/cpp/OscillatorNode/OscillatorNodeWrapper.h
@@ -18,13 +18,11 @@ namespace audiocontext {
 #ifdef ANDROID
     private:
         std::shared_ptr<OscillatorNode> oscillator_;
-#endif
-
     public:
-#ifdef ANDROID
-    explicit OscillatorNodeWrapper( std::shared_ptr<OscillatorNode> oscillator) : AudioNodeWrapper(
-            oscillator), oscillator_(oscillator) {}
+        explicit OscillatorNodeWrapper(const std::shared_ptr<OscillatorNode> &oscillator) : AudioNodeWrapper(
+                oscillator), oscillator_(oscillator) {}
 #else
+    public:
         explicit OscillatorNodeWrapper() {}
 #endif
         double getFrequency();
@@ -32,7 +30,6 @@ namespace audiocontext {
         std::string getType();
         void start(double time);
         void stop(double time);
-
         void setFrequency(double frequency);
         void setDetune(double detune);
         void setType(const std::string& type);

From 276d5f003dfc29606abc079774ac458fdba5f0fd Mon Sep 17 00:00:00 2001
From: Maciej Makowski <maciej.makowski@swmansion.com>
Date: Thu, 25 Jul 2024 13:42:31 +0200
Subject: [PATCH 5/7] refactor: code review changes

---
 android/CMakeLists.txt                        |  2 +-
 android/src/main/cpp/AudioDestinationNode.cpp |  1 -
 example/src/App.tsx                           | 52 +++++++++----------
 3 files changed, 26 insertions(+), 29 deletions(-)
 delete mode 100644 android/src/main/cpp/AudioDestinationNode.cpp

diff --git a/android/CMakeLists.txt b/android/CMakeLists.txt
index b1c84c22..39f3a80d 100644
--- a/android/CMakeLists.txt
+++ b/android/CMakeLists.txt
@@ -28,7 +28,7 @@ add_library(react-native-audio-context SHARED
         src/main/cpp/OnLoad.cpp
         src/main/cpp/AudioContext
         src/main/cpp/OscillatorNode
-        src/main/cpp/AudioDestinationNode
+        src/main/cpp/AudioDestinationNode.h
         src/main/cpp/AudioNode
         src/main/cpp/GainNode
 
diff --git a/android/src/main/cpp/AudioDestinationNode.cpp b/android/src/main/cpp/AudioDestinationNode.cpp
deleted file mode 100644
index b89481a4..00000000
--- a/android/src/main/cpp/AudioDestinationNode.cpp
+++ /dev/null
@@ -1 +0,0 @@
-#include "AudioDestinationNode.h"
diff --git a/example/src/App.tsx b/example/src/App.tsx
index 34dbe288..e77ef58c 100644
--- a/example/src/App.tsx
+++ b/example/src/App.tsx
@@ -35,17 +35,27 @@ const App = () => {
     gainRef.current.connect(destination);
   };
 
-  const handleSliderChange = (
-    value: number[],
-    defaultValue: number,
-    setValue: (value: number) => void,
-    ref: React.MutableRefObject<{ [key: string]: any } | null>,
-    propName: string
-  ) => {
-    const newValue = value[0] || defaultValue;
-    setValue(newValue);
-    if (ref.current) {
-      ref.current[propName] = newValue;
+  const handleGainChange = (value: number[]) => {
+    const newValue = value[0] || 0.0;
+    setGain(newValue);
+    if (gainRef.current) {
+      gainRef.current.gain = newValue;
+    }
+  };
+
+  const handleFrequencyChange = (value: number[]) => {
+    const newValue = value[0] || 440;
+    setFrequency(newValue);
+    if (oscillatorRef.current) {
+      oscillatorRef.current.frequency = newValue;
+    }
+  };
+
+  const handleDetuneChange = (value: number[]) => {
+    const newValue = value[0] || 0;
+    setDetune(newValue);
+    if (oscillatorRef.current) {
+      oscillatorRef.current.detune = newValue;
     }
   };
 
@@ -83,12 +93,10 @@ const App = () => {
         <Slider
           containerStyle={styles.slider}
           value={gain}
-          onValueChange={(value) =>
-            handleSliderChange(value, 0.0, setGain, gainRef, 'gain')
-          }
+          onValueChange={handleGainChange}
           minimumValue={0.0}
           maximumValue={1.0}
-          step={0.1}
+          step={0.01}
         />
       </View>
       <View style={styles.container}>
@@ -96,15 +104,7 @@ const App = () => {
         <Slider
           containerStyle={styles.slider}
           value={frequency}
-          onValueChange={(value) =>
-            handleSliderChange(
-              value,
-              440,
-              setFrequency,
-              oscillatorRef,
-              'frequency'
-            )
-          }
+          onValueChange={handleFrequencyChange}
           minimumValue={120}
           maximumValue={1200}
           step={10}
@@ -115,9 +115,7 @@ const App = () => {
         <Slider
           containerStyle={styles.slider}
           value={detune}
-          onValueChange={(value) =>
-            handleSliderChange(value, 0, setDetune, oscillatorRef, 'detune')
-          }
+          onValueChange={handleDetuneChange}
           minimumValue={0}
           maximumValue={100}
           step={1}

From 92568e082b56802666b110b93fe3c6ecc85cec83 Mon Sep 17 00:00:00 2001
From: Maciej Makowski <maciej.makowski@swmansion.com>
Date: Thu, 25 Jul 2024 14:20:24 +0200
Subject: [PATCH 6/7] fix: linting fix

---
 example/src/App.tsx | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/example/src/App.tsx b/example/src/App.tsx
index 2490feb0..9aac829d 100644
--- a/example/src/App.tsx
+++ b/example/src/App.tsx
@@ -14,7 +14,7 @@ const App: React.FC = () => {
   const [gain, setGain] = useState<number>(1.0);
   const [frequency, setFrequency] = useState<number>(440);
   const [detune, setDetune] = useState<number>(0);
-  
+
   const audioContextRef = useRef<AudioContext | null>(null);
   const oscillatorRef = useRef<Oscillator | null>(null);
   const gainRef = useRef<Gain | null>(null);
@@ -29,7 +29,7 @@ const App: React.FC = () => {
 
     gainRef.current = audioContextRef.current.createGain();
     gainRef.current.gain = gain;
-      
+
     if (Platform.OS === 'android') {
       const destination = audioContextRef.current.destination;
       oscillatorRef.current.connect(destination!);
@@ -59,7 +59,7 @@ const App: React.FC = () => {
       oscillatorRef.current.detune = newValue;
     }
   };
-  
+
   useEffect(() => {
     return () => {
       oscillatorRef.current?.stop(0);

From 9749b8d0bb14d5da0b0c577d6488e08d000f8c72 Mon Sep 17 00:00:00 2001
From: Maciej Makowski <maciej.makowski@swmansion.com>
Date: Thu, 25 Jul 2024 14:29:43 +0200
Subject: [PATCH 7/7] fix: fix merge unwanted changes

---
 cpp/OscillatorNode/OscillatorNodeWrapper.h |  4 ----
 example/src/App.tsx                        |  5 +++--
 src/AudioContext.ts                        | 24 ----------------------
 src/modules/global.d.ts                    |  1 +
 4 files changed, 4 insertions(+), 30 deletions(-)
 delete mode 100644 src/AudioContext.ts

diff --git a/cpp/OscillatorNode/OscillatorNodeWrapper.h b/cpp/OscillatorNode/OscillatorNodeWrapper.h
index fefc2642..cf37e9d0 100644
--- a/cpp/OscillatorNode/OscillatorNodeWrapper.h
+++ b/cpp/OscillatorNode/OscillatorNodeWrapper.h
@@ -17,10 +17,6 @@ namespace audiocontext {
     class OscillatorNodeWrapper: public AudioNodeWrapper {
 #ifdef ANDROID
         std::shared_ptr<OscillatorNode> oscillator_;
-#else
-        std::shared_ptr<IOSOscillator> oscillator_;
-#endif
-
     public:
         explicit OscillatorNodeWrapper(const std::shared_ptr<OscillatorNode> &oscillator) : AudioNodeWrapper(
                 oscillator), oscillator_(oscillator) {}
diff --git a/example/src/App.tsx b/example/src/App.tsx
index 9aac829d..cd16e67c 100644
--- a/example/src/App.tsx
+++ b/example/src/App.tsx
@@ -32,7 +32,8 @@ const App: React.FC = () => {
 
     if (Platform.OS === 'android') {
       const destination = audioContextRef.current.destination;
-      oscillatorRef.current.connect(destination!);
+      oscillatorRef.current.connect(gainRef.current);
+      gainRef.current.connect(destination!);
     }
   };
 
@@ -90,7 +91,7 @@ const App: React.FC = () => {
         />
       </View>
       <View style={styles.container}>
-        <Text>Gain: {gain.toFixed(1)}</Text>
+        <Text>Gain: {gain.toFixed(2)}</Text>
         <Slider
           containerStyle={styles.slider}
           value={gain}
diff --git a/src/AudioContext.ts b/src/AudioContext.ts
deleted file mode 100644
index 7f36e857..00000000
--- a/src/AudioContext.ts
+++ /dev/null
@@ -1,24 +0,0 @@
-import { NativeModules, Platform } from 'react-native';
-
-import type {
-  AudioDestinationNode,
-  BaseAudioContext,
-  Oscillator,
-} from './types';
-
-export class AudioContext implements BaseAudioContext {
-  destination: AudioDestinationNode | null;
-
-  constructor() {
-    this.destination = null;
-
-    if (Platform.OS === 'android') {
-      NativeModules.AudioContextModule.installAudioContext();
-      this.destination = global.__AudioContext.destination;
-    }
-  }
-
-  createOscillator(): Oscillator {
-    return global.__AudioContext.createOscillator();
-  }
-}
diff --git a/src/modules/global.d.ts b/src/modules/global.d.ts
index b7dc178b..85cdb3e6 100644
--- a/src/modules/global.d.ts
+++ b/src/modules/global.d.ts
@@ -2,6 +2,7 @@ import type { Oscillator } from '../types';
 
 type AudioContext = {
   createOscillator: () => Oscillator;
+  createGain: () => Gain;
   destination: AudioDestinationNode | null;
 };