Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve README and code comprehensibility #286

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Sidnioulz
Copy link

Hi folks,

This is a tiny PR with two commits that:

  • Ensure all the delay implementations use the same vocabulary as the documented retryDelay option
  • Add more details to documentation on delay handling, including noDelay and an advanced exponentialDelay example, and a Retry-Header behaviour explanation

I've taken upon to writing this because I initially did not notice that axios-retry handled these things out of the box and coded them on my end, until I stumbled upon the source code. I hope this PR will help prospective users better understand the capabilities of this plugin :)

Copy link
Member

@mindhells mindhells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants