Unable to process when there are two type of comparison lamps.

[simontorres]

Given the following group of comparison lamps for a given target the pipeline fails to process it because the lamps CuHeAr 600_MID are not in the reference library due to this.

the method goodman_pipeline.core.ReferenceData.check_comp_group returns at the first iteration despite having a for loop to check all configurations. The problem with this is that it does not filter out the CuHeAr lamps.

                         file        date           slit                 date-obs obstype         object  exptime  ... lamp_hga lamp_ne lamp_ar  lamp_fe  lamp_cu   radeg decdeg
2   cfzst_0199_comp_600m.fits  2021-04-15  1.5_LONG_SLIT  2021-04-15T09:24:47.125    COMP   CuHeAr  600M    120.0  ...    FALSE   FALSE   FALSE    FALSE     TRUE  226.78   1.54
3   cfzst_0197_comp_600m.fits  2021-04-15  1.5_LONG_SLIT  2021-04-15T09:23:25.997    COMP  HgAr Ne  600M      0.5  ...     TRUE    TRUE   FALSE    FALSE    FALSE  226.78   1.54
14  cfzst_0200_comp_600m.fits  2021-04-15  1.5_LONG_SLIT  2021-04-15T09:27:10.716    COMP   CuHeAr  600M    120.0  ...    FALSE   FALSE   FALSE    FALSE     TRUE  226.78   1.54
15  cfzst_0196_comp_600m.fits  2021-04-15  1.5_LONG_SLIT  2021-04-15T09:23:01.915    COMP  HgAr Ne  600M      0.5  ...     TRUE    TRUE   FALSE    FALSE    FALSE  226.78   1.54
32  cfzst_0198_comp_600m.fits  2021-04-15  1.5_LONG_SLIT  2021-04-15T09:23:50.037    COMP  HgAr Ne  600M      0.5  ...     TRUE    TRUE   FALSE    FALSE    FALSE  226.78   1.54

Also the problem is that this causes the processing of that particular science file to end with the the first incompatible lamp.

[2021-06-04 20:34:57][    INFO]: Starting Wavelength calibration of Science Target: NGC 5850 File: ecfzst_0193_obj_600m.fits. [wavelength.__call__:158]
[2021-06-04 20:34:57][   DEBUG]: Science file ecfzst_0193_obj_600m.fits has 5 comparison lamps. [wavelength.__call__:171]
[2021-06-04 20:34:57][    INFO]: Using reference lamp ecfzst_0199_comp_600m_365.12-400.20.fits [wavelength.__call__:176]
[2021-06-04 20:34:57][    INFO]: Processing Comparison Lamp: CuHeAr  600M [wavelength.__call__:182]
[2021-06-04 20:34:57][   DEBUG]: New Order:  5 [core.get_lines_in_lamp:1620]
[2021-06-04 20:34:57][    INFO]: Searching matching reference lamp [core.get_reference_lamp:3858]
[2021-06-04 20:34:57][   ERROR]: Unable to find a match for: LAMP_HGA = FALSE, LAMP_NE = FALSE, LAMP_AR = FALSE, LAMP_FE = FALSE, LAMP_CU = TRUE, WAVMODE = 600_MID  [core.get_reference_lamp:3879]
[2021-06-04 20:34:57][   ERROR]: Unable to find a match for: LAMP_HGA = FALSE, LAMP_NE = FALSE, LAMP_AR = FALSE, LAMP_FE = FALSE, LAMP_CU = TRUE, WAVMODE = 600_MID  [redspec._run:552]
[2021-06-04 20:34:57][   DEBUG]: End of process for file cfzst_0193_obj_600m.fits. [redspec._run:556]