feat: new setting for consistent ignores [IDE-714] #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acke
changed the base branch from
main
to
feat/IDE-711_create_a_new_snyk_view
…d snykCodeConsistentIgnores
ShawkyZ
reviewed
Nov 21, 2024
plugin/src/main/java/io/snyk/languageserver/protocolextension/SnykExtendedLanguageClient.java
Outdated
Show resolved
Hide resolved
ShawkyZ
reviewed
Nov 21, 2024
| @@ -19,7 +16,17 @@ public IssueTreeNode(Issue issue) { | |||
|
|
|||
| @Override | |||
| public String getText() { | |||
| return getIssue().getDisplayTitle(); | |||
| String displayTitle = getIssue().getDisplayTitle(); | |||
|
|
|||
There was a problem hiding this comment.
I think it's better if this logic is in getDisplayTitle
There was a problem hiding this comment.
There is no getDisplayTitle function to override, or did I misunderstand what you are asking here?
…new-setting-for-consistent-ignores
ShawkyZ
reviewed
Nov 21, 2024
plugin/src/main/java/io/snyk/languageserver/protocolextension/SnykExtendedLanguageClient.java
Outdated
Show resolved
Hide resolved
ShawkyZ
changed the title
ShawkyZ
approved these changes
Nov 22, 2024
ShawkyZ
added a commit
that referenced
this pull request
Nov 25, 2024
* feat: add view with tree view, browser and toolbar buttons * feat: added initial text and image to browser view. No styling! * fix: added buttons and handlers for product activation * fix: update the string for use in Eclipse * feat: Added Tree and View Menu * tidy: fix imports * fix: cleanup image when plugin is shuting down * feat: enable/disable products, viewmenu buttons and preferencepage * fix: added filters to preferencesstore * fix: added handlers for each severity * chore: remove JAVASE-21 from manifest * feat: add interfaces and first functionality to retrieve html * fix: tests * fix: use basehandler for handlers * tidy: rename rootobject to rootnode * feat: updated viewmenu and added handlers for stop scan and clear cache commands * feat/IDE-712_populate-the-tree-view-with-publish-diagnostics-data-from-IaC,-Open-Source-and-Code,-using-a-local-cache (#215) * chore: wip * fix: add info nodes for no issues found and no fixable issues found * fix: tests * feat: add initial tree filling impl * feat: display info nodes * feat: add generic filter method to cache * feat: show view when scanning * feat: choose the right icon for root nodes in the treeview * tidy: remove the open preference action, replaced by preference handler * fix: removed conflicting handlers * feat/clear cache on command * fix: move strings to bundle.properties * fix: also clear scanstate when clearing cache * fix: added a SnykIcon class for all imagedescriptors and added collaps/expand treeviewer. * feat: adding logic for fixable issues filter. * fix: updated UX to use enabled/disabled icons * chore: added unit test for BaseTreeNode * tidy: make fixable comments more clear * fix: update lsconfiguration when preferences has been updated * tidy: reformat unit tests * fix: call ui updates after state updates * fix: handle enable/disable of tree filters * fix: remove unneeded ImageDescriptorProvider * fix: update Ignores Preferences and some tidying * feat: populate tree [IDE-712] (#218) * feat: add project level * fix: tests * feat: add file & issue nodes (wip) * feat: add issue navigation * fix: add missing icons * fix: node filtering * fix: create custom publishDiagnostic for faster deserilization * fix: use Webview2 browser on Windows * chore: added comment * wip: cancel all scans * tidy: clean up unused things * fix: clean up tree when scan is cancelled * fix: expand treenodes after product nodes are added to tree * fix: added unit tests for progressmanager * fix: indentation * fix: dont run progress cancellation in UI --------- Co-authored-by: Knut Funkel <[email protected]> Co-authored-by: Abdelrahman Shawki Hassan <[email protected]> * fix: progress manager and tests (#222) * Fix/tests (#223) fix: tests on command line * feat: add product node suffixes (#224) * feat: new setting for consistent ignores [IDE-714] (#221) * feat: prepending the treenodes for ignores and AI Fix with identifier * fix: added space after ignore tag * feat: add a call to read feature flags, and call that function to read snykCodeConsistentIgnores * fix: expand treeviewer to show all issues. * fix: wip remvoe ignores filters if needed * fix: rename file * fix: call featureflag service after auth and settings persistence * fix: notifyProgress if param is null * feat: taskprocessor for sending tasks after ls init * fix: tests use current pref * feat: filter issues based on ignore preferences * fix: remove commands if ff for ignores are false * fix: adding the handlers and commands for filters * fix: adding an asyncExec on the ui updates --------- Co-authored-by: Abdelrahman Shawki Hassan <[email protected]> * feat: style description panel (#220) * wip: html provider * fix: populate tree after snyk.Scan success * refactor: use css from LS * wip: html provider * fix: merge conflicts * fix: added HtmlProviderFactory tests * fix: use comperator for sorting issues * refactor: create BrowserHandler * fix: cache theme instance * fix: cache test * fix: HtmlProviderTest doesn't extend LsBaseTest * fix: ignore calling workbench if in test * fix: assert nonexisting string * fix: publishDiagnostics tests * fix: dont get workbench if test --------- Co-authored-by: Bastian Doetsch <[email protected]> Co-authored-by: Abdelrahman Shawki Hassan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide description of this PR and changes, if linked Jira ticket doesn't cover it in full.
Checklist
Screenshots / GIFs
Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!