Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

classy-prelude-yesod not offereing much value over Import.hs #90

Open
gregwebs opened this issue Nov 29, 2014 · 2 comments
Open

classy-prelude-yesod not offereing much value over Import.hs #90

gregwebs opened this issue Nov 29, 2014 · 2 comments

Comments

@gregwebs
Copy link
Collaborator

given that classy-prelude-yesod is just an import list, I would rather just put it in the scaffold in Import.hs. I have a couple issues with it as is:

  • adds an extra dependencies such as yesod-newsfeed
  • exports Sql stuff by default that not everyone needs

Once these are taken out there isn't much left.

What I would envision for classy-prelude-yesod is to change the type signatures of Yesod functions to work with more data structures via classy-prelude.

@snoyberg
Copy link
Owner

I'd still say we should leave the scaffolding as-is, since it's easier to update a library than the scaffolding.

@snoyberg
Copy link
Owner

Sorry, I should clarify. I have no objection in principle to the kinds of changes you're implying for the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants