Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage different types appropriately in filters #186

Open
colmsnowplow opened this issue Aug 8, 2022 · 0 comments
Open

Manage different types appropriately in filters #186

colmsnowplow opened this issue Aug 8, 2022 · 0 comments

Comments

@colmsnowplow
Copy link
Collaborator

As it stands, we use fmt.Sprint() to coerce non-string values to string for purposes of evaluating via regex. This is obviously not brilliant, but we get away with it because a) typically people will mostly need string and int, b) we know what other types will be cast to, and c) scripting transformations can be used to cover other cases if need be.

We should design and instrument something better for other types - off the top of my head I think we could either go with a) a separate filter for different types, or b) handling different types explicitly in the existing filter. Not sure which is better.

This was referenced Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant