Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync tox with codecov requirements #1448

Open
ajratner opened this issue Sep 5, 2019 · 1 comment
Open

Sync tox with codecov requirements #1448

ajratner opened this issue Sep 5, 2019 · 1 comment
Assignees
@henryre
Labels
feature request no-stale Auto-stale bot skips this issue

Comments

@ajratner
Copy link
Contributor

ajratner commented Sep 5, 2019

Is your feature request related to a problem? Please describe.

tox passes locally- including running coverage- but then codecov fails and blocks the PR.

Describe the solution you'd like

It's debatable how high the bar for maintaining coverage should be, and to what degree this is counterproductive friction... but either way, it would be more efficient if tox just failed, so could fix locally, and then be assured PR codecov test would pass.
@vincentschen vincentschen added the no-stale Auto-stale bot skips this issue label Nov 18, 2019
@imskr
Copy link

imskr commented Feb 6, 2021

I would like to work on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@henryre henryre

Labels
feature request no-stale Auto-stale bot skips this issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ajratner @vincentschen @henryre @imskr