Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet and Risk Management #6

Open
sneilan opened this issue Oct 21, 2023 · 2 comments
Open

Wallet and Risk Management #6

sneilan opened this issue Oct 21, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@sneilan
Copy link
Owner

sneilan commented Oct 21, 2023

When a user is first created, they should have a balance gifted to them by the administrator. Perform risk checks for every trade and make sure user has enough money in their wallet.

@sneilan sneilan added the enhancement New feature or request label Oct 21, 2023
@sneilan sneilan self-assigned this Oct 21, 2023
@sreyas-p
Copy link

what factors would the risk checks need to consider other than the user's balance? (I am interested in contributing to this project)

@sneilan
Copy link
Owner Author

sneilan commented Nov 22, 2023

Totally! Here's some I thought of for a server like this that will eventually be public facing. They prevent DDOS attacks and out of memory crashes. There are other types of risk factors involving margin, options, total market activity but that is not on the roadmap yet.

  1. How many trades a user has open. Is the user trading too much? (too many trades open = server runs out of memory)
  2. How big is a trade relative to other trades in the market (a huge trade means a long time to fill it. potential DDOS attack)
  3. How many trades are live across all users? (Should rate limit trades when too many trades open to prevent server crashing)

It may be hard to implement these features without user accounts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants