From cc1ef75953fc33e178ac6102ec7f21536a7753c7 Mon Sep 17 00:00:00 2001 From: pscott <30843220+pscott@users.noreply.github.com> Date: Tue, 10 Oct 2023 15:19:32 +0200 Subject: [PATCH] audit: L-02 No Gap Variable (#591) * fix: use gaps in SimpleQuorumExecutionStrategy and StarnketSpaceManager --------- Co-authored-by: Orland0x <37511817+Orland0x@users.noreply.github.com> --- .../execution-strategies/SimpleQuorumExecutionStrategy.sol | 5 +++++ ethereum/src/execution-strategies/StarknetSpaceManager.sol | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/ethereum/src/execution-strategies/SimpleQuorumExecutionStrategy.sol b/ethereum/src/execution-strategies/SimpleQuorumExecutionStrategy.sol index a4c827b98..dfba4a911 100644 --- a/ethereum/src/execution-strategies/SimpleQuorumExecutionStrategy.sol +++ b/ethereum/src/execution-strategies/SimpleQuorumExecutionStrategy.sol @@ -76,4 +76,9 @@ abstract contract SimpleQuorumExecutionStrategy is IExecutionStrategy, StarknetS } function getStrategyType() external view virtual override returns (string memory); + + /// @dev This empty reserved space is put in place to allow future versions to add new + /// variables without shifting down storage in the inheritance chain. + /// See https://docs.openzeppelin.com/contracts/4.x/upgradeable#storage_gaps + uint256[49] private __gap; } diff --git a/ethereum/src/execution-strategies/StarknetSpaceManager.sol b/ethereum/src/execution-strategies/StarknetSpaceManager.sol index a2383f433..d8f594bc1 100644 --- a/ethereum/src/execution-strategies/StarknetSpaceManager.sol +++ b/ethereum/src/execution-strategies/StarknetSpaceManager.sol @@ -57,4 +57,9 @@ contract StarknetSpaceManager is OwnableUpgradeable { if (spaces[space] == FALSE) revert InvalidSpace(); _; } + + /// @dev This empty reserved space is put in place to allow future versions to add new + /// variables without shifting down storage in the inheritance chain. + /// See https://docs.openzeppelin.com/contracts/4.x/upgradeable#storage_gaps + uint256[49] private __gap; }