Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat fetch testnet space avatar from stamp #4911

Merged
merged 4 commits into from
Oct 9, 2024
Merged

Feat fetch testnet space avatar from stamp #4911

merged 4 commits into from
Oct 9, 2024

Conversation

wa0x6e
Copy link
Collaborator

@wa0x6e wa0x6e commented Oct 9, 2024 •
edited
Loading

Summary

Closes: https://github.com/snapshot-labs/workflow/issues/220
Following and depending on #4909

This PR shows the testnet or mainnet space avatar, depending on the app environment

How to test

  1. Go to http://localhost:8080/#/diva-testing.eth/settings
  2. It should show a custom space avatar

@wa0x6e wa0x6e requested a review from ChaituVR October 9, 2024 10:30
ChaituVR
ChaituVR approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck

@ChaituVR ChaituVR merged commit 8059733 into master Oct 9, 2024
3 of 5 checks passed
@ChaituVR ChaituVR deleted the feat-fetch-testnet-space-avatar-from-stamp branch October 9, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChaituVR ChaituVR ChaituVR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wa0x6e @ChaituVR