fix: optimize spaces helpers #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into fix-use-counter-columns-from-spaces-table
ChaituVR
reviewed
Jul 17, 2024
ChaituVR
requested changes
Jul 17, 2024
|
I think solution should be to ignore total counts here in these queries, but use space counts directly on |
wa0x6e
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new
vote_count,proposal_countandfollower_countcolumns from the spaces table to retrieve total number of items per space, instead of using aCOUNT(id) as COUNTselect.Also some refactoring to add types, and cleaning.
The whole script now run in 40 seconds (instead of > 10 minutes), with 95% of the time spend on loading all spaces.
How to test