WIP: Setup discord bot #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 27, 2022 17:29
2 tasks
|
Hey @ChaituVR could you have a look at this PR? Refactoring of the client can be done in a separate PR 🙏 |
ChaituVR
requested changes
Jan 31, 2023
Comment on lines
+14
to
+24
| router.post('/event-to-subscribers', async (req, res) => { | ||
| const event: string = req.body.event || ''; | ||
| const proposalId: string = req.body.proposalId || ''; | ||
|
|
||
| try { | ||
| await sendEventToDiscordSubscribers(event, proposalId); | ||
| return res.json({ success: true }); | ||
| } catch (e) { | ||
| return res.json({ error: e }); | ||
| } | ||
| }); |
There was a problem hiding this comment.
- We should make sure this route is used only by us.
- snapshot-webhook sends a secret in the
authenticationheader, Example: 
- We can add a variable in .env and check if the header is equal or not (for development env can be empty)
- For
const proposalId: string = req.body.proposalId || '';
In the event payload proposal id is proposal.id
| @@ -0,0 +1,39 @@ | |||
| <div align="center"> | |||
There was a problem hiding this comment.
Something is weird here https://github.com/snapshot-labs/discord-bot/tree/setup-discord-bot
I see plain html 🙈 not sure why
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes partially snapshot-webhook/40
Background
This PR sets up the Discord Bot as a separate repo from snapshot-webhook
PR details
The logic is moved from
snapshot-webhookto this repo in the following way:clientand connects to the existing Snapshot botsnapshot-webhooksnapshot-webhookCurrent implementation (there is an error with Missing access, haven't sorted it out yet but it must be my settings on Discord for the app):
Related PRs
To Dos
clientanddb@bonustrack @ChaituVR any comments welcome 🙏