Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing correctly pURLs and prefixing targets. #476

Merged
merged 4 commits into from
Nov 15, 2024

Conversation

andream16
Copy link
Contributor

@andream16 andream16 commented Nov 15, 2024

Cleaned up PR from closed #473.

  • Prefixing physical (files) targets with file://
  • Correctly lookup for pURLs which were previously ignored
  • Snyk-python and snyk-node pass more context about the language so that we can improve not well formatted pURLs
  • Ignoring test generated report.html

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11855280720

Details

  • 120 of 176 (68.18%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 40.751%

Changes Missing Coverage Covered Lines Changed/Added Lines %
components/producers/java-findsecbugs/main.go 0 1 0.0%
components/producers/kics/main.go 0 1 0.0%
components/producers/terraform-tfsec/main.go 0 1 0.0%
components/producers/snyk-docker/main.go 9 14 64.29%
pkg/sarif/sarif.go 109 157 69.43%
Totals Coverage Status
Change from base Build 11815674364: 0.5%
Covered Lines: 3485
Relevant Lines: 8552

💛 - Coveralls

@andream16 andream16 merged commit 3bb4e5c into main Nov 15, 2024
3 checks passed
@andream16 andream16 deleted the andream16/prefix-targets-v2 branch November 15, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants