Multi-platform builds v3 #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
northdpole
approved these changes
Sep 16, 2024
This commit extends the base Dockerfile so that it can copy a binary from an arbitrary path and copy it into a target one inside the filesystem of the container image. The scripts building the component binaries and containers have also been extended with environment variables to help them build the binaries for the expected architecture. The Makefile has acquired also the same environment variable which are set by default in the host's architecture. In the case of the `dev-deploy` target, the architecture is set by default to `linux/amd64` since containers are usually executed on linux/amd64 systems or on linux/amd64 VMs running the Docker daemon (Windows, some Macs) or on VMs running linux/arm64 which supports amd64 binaries out of the box.
…RCH for building binaries. Bumping remark-cli to suppress errors and warnings on linting markdown files.
andream16
force-pushed
the
ptzianos/feature-334/multi-platform-builds-v3
branch
from
8a147a7 to
bc7a9ac
Compare
andream16
approved these changes
Sep 16, 2024
northdpole
deleted the
ptzianos/feature-334/multi-platform-builds-v3
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.