Bugfix/344 add certificates to consumers #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andream16
approved these changes
Sep 12, 2024
ptzianos
reviewed
Sep 12, 2024
northdpole
force-pushed
the
bugfix/344-add-certificates-to-consumers
branch
2 times, most recently
from
a7030b8 to
a62258f
Compare
northdpole
force-pushed
the
bugfix/344-add-certificates-to-consumers
branch
3 times, most recently
from
0a4e840 to
71a3930
Compare
andream16
approved these changes
Sep 13, 2024
northdpole
force-pushed
the
bugfix/344-add-certificates-to-consumers
branch
from
71a3930 to
ef50fe0
Compare
andream16
reviewed
Sep 13, 2024
andream16
previously requested changes
Sep 13, 2024
There was a problem hiding this comment.
Left a comment for the Makefile.
I also tried to build the containers using make components but I get the following error when running one of them:
docker: Error response from daemon: failed to create task for container: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: exec: "/app/${executable_path}": stat /app/${executable_path}: no such file or directory: unknown.
It seems like executable_path is not getting interpolated correctly 🤔
andream16
reviewed
Sep 13, 2024
northdpole
force-pushed
the
bugfix/344-add-certificates-to-consumers
branch
2 times, most recently
from
5977e62 to
98848f1
Compare
ptzianos
reviewed
Sep 13, 2024
northdpole
force-pushed
the
bugfix/344-add-certificates-to-consumers
branch
2 times, most recently
from
be45f79 to
b90b1da
Compare
ptzianos
force-pushed
the
bugfix/344-add-certificates-to-consumers
branch
from
b90b1da to
34d50c8
Compare
…that has certificates
…tes since now the base image has certs
ptzianos
force-pushed
the
bugfix/344-add-certificates-to-consumers
branch
from
34d50c8 to
a2794ba
Compare
ptzianos
approved these changes
Sep 13, 2024
dlicheva
approved these changes
Sep 13, 2024
ptzianos
dismissed
andream16’s stale review
fixed in the latest round of changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #344 by adding certificates to consumers