Feature/ocu 184 allow binaries and containers to be built for architectures different than amd #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or better compatibility on different machines. Defaulting to linux/amd64 and allowing for customization.
…th a platform for better compatibility.
…RCH for building binaries. Bumping remark-cli to suppress errors and warnings on linting markdown files.
ptzianos
reviewed
Sep 11, 2024
| executable_src_path=$(dirname "${1}") | ||
| executable_path=$(dirname "${1}")/"${executable}" | ||
| executable_src_path=$(dirname $dir_name) | ||
| executable_path=$(dirname $dir_name)/${build_architecture}/"${executable}" |
There was a problem hiding this comment.
nit: can you encapsulate please the BASH variables in curly brackets here and here: eea4040#diff-e886250d151c99b2b701ddeab8e0e58bcac8f434e02ead4aafaab12462fa8e86R25 for consistency?
| $$([ "${SOURCE_CODE_REPO}" != "" ] && echo "--label=org.opencontainers.image.source=${SOURCE_CODE_REPO}" ) \ | ||
| -f containers/Dockerfile.draconctl . | ||
| -f containers/Dockerfile.draconctl . \ | ||
| --platform=$(CONTAINER_OS_ARCH) |
There was a problem hiding this comment.
as far as I can see this is the only point where the CONTAINER_OS_ARCH is used. can we replace it with just $(GOOS)/$(GOARCH)
ptzianos
approved these changes
Sep 11, 2024
|
Closed in favour of https://github.com/ocurity/dracon/pull/350/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title, allow to customise the built images and binaries for 🍎 people and documenting the utilisation.
We basically use --platform when building to specify for which platform we want to build an image. At the same time we can customise for which architecture the Go binaries should be built for.
Based on the supplied ARCH and OS, a binary is created in a self-documented sub-folder, as follows:
It would be nice to collapse the different
Dockerfiles andMakefiles in components into a single one, so such customisation can be centralised. I'll start a thread in the chat about it.Tested locally:
make components-> builds withlinux/amd64by default. Running the containers works fine.make GOOS=linux GOARCH=arm64 CONTAINER_OS_ARCH=linux/arm64 components-> builds withlinux/arm64. Running the containers work.make GOOS=darwin GOARCH=arm64 component-binaries-> build withdarwin/arm64and I can exec the binaries fine on my machine.I would appreciate if you can try these commands yourself and if you have other pointers to what to test.
Minor: bumping
remark-clito v12.0.1 to suppress formatting errors.