From 19ad9c806f2c6d843ad314c2cf035cdf26dc1384 Mon Sep 17 00:00:00 2001 From: sg Date: Wed, 5 Jun 2024 11:34:50 +0100 Subject: [PATCH] current linter setup is very noisy, also reviewdog's github integration has a bug that double/tripple reports findings on removed code, however, when running locally, the linter works as expected, so we do the same for ci/cd --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index f0c6308bd..8ce0e8612 100644 --- a/Makefile +++ b/Makefile @@ -92,7 +92,7 @@ clean: clean-protos clean-migrations-compose .PHONY: lint install-lint-tools tests go-tests fmt fmt-proto fmt-go install-go-fmt-tools migration-tests lint: - @reviewdog -fail-on-error $$([ "${CI}" = "true" ] && echo "-reporter=github-pr-review") -diff="git diff origin/main" -filter-mode=added -tee + @reviewdog -fail-on-error -diff="git diff origin/main" -filter-mode=added -tee install-lint-tools: @go install honnef.co/go/tools/cmd/staticcheck@latest