Make HTTPFileLoader more intelligent (Fixes #128) #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
northdpole
approved these changes
Apr 15, 2024
ptzianos
force-pushed
the
ptzianos/make-file-loading-more-interlligent
branch
from
16d6e5f to
323f11f
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ptzianos
force-pushed
the
ptzianos/make-file-loading-more-interlligent
branch
2 times, most recently
from
3ff8220 to
323f11f
Compare
added 2 commits
April 16, 2024 15:01
Splits away the Loader and its implementations into the pkg/files module and adds more logic to the HTTPFileLoader so that it can append the target file to the URL if it's missing. Tests are also added to make sure that the HTTPFileLoader is 100% covered now. A new interface and a mock implementation has been added for HTTP requests.
ptzianos
force-pushed
the
ptzianos/make-file-loading-more-interlligent
branch
from
323f11f to
51596f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits away the Loader and its implementations into the pkg/files module and adds more logic to the HTTPFileLoader so that it can append the target file to the URL if it's missing. Tests are also added to make sure that the HTTPFileLoader is 100% covered now.
A new interface and a mock implementation has been added for HTTP requests.