Fix httpFileLoader to only return an error when a problem has occurred #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptzianos
force-pushed
the
ptzianos/remote-task-files
branch
2 times, most recently
from
9cc4084 to
1143f7c
Compare
flowirtz
approved these changes
Apr 8, 2024
northdpole
approved these changes
Apr 8, 2024
…y#126) This commit moves some code away from the build command, that manages the loading of the base pipeline, task and the pipeline tasks into a separate piece of code that lives in the same directory as the Tekton backend. Some tests are also added to the codebase testing the correct returning of errors. Finally, it fixes the issue where the httpFileLoader returns an error wrapping a nil error even if the file has been fetched from the remote source correctly. Signed-off-by: Pavlos Tzianos <[email protected]>
ptzianos
force-pushed
the
ptzianos/remote-task-files
branch
from
1143f7c to
4d9fee8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #126