From 1677b01b00d81cd1106352dd5da8fcceb4980752 Mon Sep 17 00:00:00 2001 From: Pavlos Tzianos Date: Wed, 5 Jun 2024 12:07:58 +0100 Subject: [PATCH] redirect reviewdog stderr to stdout the lint Make target will output in stderr all the issues that reviewdog discovered for the diff under investigation, however that stderr is not captured by the Github action. we need to send the stderr to stdout so that we can see it in the Github action logs when the lint action fails. --- Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index f2ebf42e9..44100650d 100644 --- a/Makefile +++ b/Makefile @@ -92,7 +92,8 @@ clean: clean-protos clean-migrations-compose .PHONY: lint install-lint-tools tests go-tests fmt fmt-proto fmt-go install-go-fmt-tools migration-tests lint: - @reviewdog -fail-on-error -diff="git diff origin/main" -filter-mode=added +# we need to redirect stderr to stdout because Github actions don't capture the stderr lolz + @reviewdog -fail-on-error -diff="git diff origin/main" -filter-mode=added 2>&1 install-lint-tools: @go install honnef.co/go/tools/cmd/staticcheck@latest