Skip to content

Commit

Permalink
redirect reviewdog stderr to stdout
Browse files Browse the repository at this point in the history
the lint Make target will output in stderr all the issues that
reviewdog discovered for the diff under investigation, however that
stderr is not captured by the Github action. we need to send the stderr
to stdout so that we can see it in the Github action logs when the lint
action fails.
  • Loading branch information
Pavlos Tzianos committed Jun 5, 2024
1 parent 3c0fcc4 commit 1677b01
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,8 @@ clean: clean-protos clean-migrations-compose
.PHONY: lint install-lint-tools tests go-tests fmt fmt-proto fmt-go install-go-fmt-tools migration-tests

lint:
@reviewdog -fail-on-error -diff="git diff origin/main" -filter-mode=added
# we need to redirect stderr to stdout because Github actions don't capture the stderr lolz
@reviewdog -fail-on-error -diff="git diff origin/main" -filter-mode=added 2>&1

install-lint-tools:
@go install honnef.co/go/tools/cmd/staticcheck@latest
Expand Down

0 comments on commit 1677b01

Please sign in to comment.