Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fail to start application if LED file doesn't exist #31

Open
fhunleth opened this issue Jan 2, 2024 · 0 comments
Open

Don't fail to start application if LED file doesn't exist #31

fhunleth opened this issue Jan 2, 2024 · 0 comments

Comments

@fhunleth
Copy link
Collaborator

fhunleth commented Jan 2, 2024

Right now, if you make a typo with the LED name (or any other error), the :delux app won't start and that means that any app that depends on it won't start. This has the side effect of making some Nerves applications not boot or not complete enough of the boot process to be minimally usable. There are probably arguments here about the structure of those applications that cause this issue, but it seems better to handle configuration errors in a different way.

I think the best way now is to not set up the LED and log the error. Then whenever the application tries to set the LED, Delux should log an error again (this might be done already - I didn't check). That will make it so noisy that it will be hard to miss even if you're not looking at LEDs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant