Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common JS waring #23

Open
sannyjacobsson opened this issue Sep 16, 2020 · 1 comment
Open

Common JS waring #23

sannyjacobsson opened this issue Sep 16, 2020 · 1 comment

Comments

@sannyjacobsson
Copy link

WARNING in node_modules\smart-table-ng_ivy_ngcc_\fesm2015\smart-table-ng.js depends on 'rxjs/index'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

"It is recommended that you avoid depending on CommonJS modules in your Angular applications. Depending on CommonJS modules can prevent bundlers and minifiers from optimizing your application, which results in larger bundle sizes. Instead, it is recommended that you use ECMAScript modules in your entire application. For more information, see How CommonJS is making your bundles larger."

Will this significantly effect the bundle size or can I safely ignore the warning?

@sannyjacobsson
Copy link
Author

@lorenzofox3 any update on this warning?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant