Skip to content
This repository has been archived by the owner on Feb 14, 2019. It is now read-only.

Any plans to migrate to bootstrap v3? #114

Closed
ghost opened this issue Aug 5, 2013 · 6 comments
Closed

Any plans to migrate to bootstrap v3? #114

ghost opened this issue Aug 5, 2013 · 6 comments

Comments

@ghost
Copy link

ghost commented Aug 5, 2013

No description provided.

@iainsmith
Copy link

+1 @zbrykit just provided a patch over here which might be helpful. tarruda/bootstrap-datetimepicker/pull/192

@zbryikt
Copy link

zbryikt commented Aug 11, 2013

bootstrap 3 is not supported because the glyphicon is moved into a standalone project, and the css class names are changed. there is also a change in collapse behavior.

@Eonasdan
Copy link

Eonasdan commented Sep 2, 2013

I fixed Bootstrap v3 issues here: https://github.com/Eonasdan/bootstrap-datetimepicker

@nvivo
Copy link

nvivo commented Sep 26, 2013

@Eonasdan your fork is from another project. I installed it then found out the code is not compatible with smalot's version.

@nvivo
Copy link

nvivo commented Sep 26, 2013

For those who need it, I did some fixes for bootstrap3 here: nvivo@d1c7839

This file works correctly with this html:

<div class="date input-group">
    <input type="text" class="form-control" readonly>
    <span class="input-group-addon"><i class="icon-remove"></i></span>
    <span class="input-group-addon"><i class="icon-th"></i></span>
</div>

I didn't migrate the icons, as the code still works fine with font-awesome.

@smalot
Copy link
Owner

smalot commented Oct 12, 2013

the bootstrap v3 support has just been released.

@smalot smalot closed this as completed Oct 12, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants