-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GraphQL field batching failing on subscription #2164
Comments
I was also facing this issue. I locked graphql-java to version 22.2 and that fixed it. |
Thanks @simenbw for investigating this! If a graphql-java update fixes the problem, that's great. |
Or given that 3.15 will be LTS, I may be able to squeeze the graphql-java update there after all, into a later micro update. I'll try that :) |
I'm having an issue when using a
@Subscription
along with a batch@Source
method. Seems like a potential regression on graphql. I've got a reproducer project here: https://github.com/cristianonicolai/graphql-playground . I also noticed that removing the batch, using a single entity as@Source
code works fine, see https://github.com/cristianonicolai/graphql-playground/blob/main/src/main/java/org/acme/GraphQLResource.java#L41Batch is not mandatory for the
PlanDTO
type in the subscription, since it will always return a single value. But since the same type is reused for a query, where batching makes sense, seeplans
query in the reproducer.The issue started to happen once trying to upgrade Quarkus from version 3.12.3 to 3.13.3 (graphql-java 21.3 to 22.1.).
Although in the reproduces it logs an error
BackPressureFailure: Could not emit tick 1 due to lack of requests
, there is no error in the logs in the real application. It silintly fails to receive any items in the subscriber. Last related log in the app is:The text was updated successfully, but these errors were encountered: