Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI lint/tests keep failing for PRs #28

Open
jessebot opened this issue Jun 9, 2024 · 0 comments
Open

CI lint/tests keep failing for PRs #28

jessebot opened this issue Jun 9, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@jessebot
Copy link
Collaborator

jessebot commented Jun 9, 2024

Need to look into it here:
https://github.com/small-hack/matrix-authentication-service-chart/actions/runs/9435550794/job/25989108128

Works fine actually deployed though 🤷

Probably has something to do with:

--------------------------------------------------------------------------------------------------
==> Logs of container matrix-authentication-service-v1smtqmj31-d4f698fdd-h6zvg
--------------------------------------------------------------------------------------------------
Error: missing field `public_base` for key "default.http" in data/config.yaml YAML file

We can probably provide that helm paramter via custom set values for the ct command in the workflow.

Parameter in question (mas.http.public_base):

http:
# -- Public URL base used when building absolute public URLs
public_base: ""

Location to provide it to:

ct install --target-branch ${{ github.event.repository.default_branch }} --helm-extra-set-args '--set=postgresql.enabled=true --set=postgresql.volumePermissions.enabled=false --set=postgresql.primary.networkPolicy.enabled=false'

@jessebot jessebot added the good first issue Good for newcomers label Jun 9, 2024
@jessebot jessebot changed the title PR lint/tests keep failing CI lint/tests keep failing for PRs Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant