- V tomto projekte nastali zmeny, ktoré nie sú zahrnuté v súčasnom hodnotení. Na aktualizácii pracujeme, môžete sa do nej
- <%= link_to 'zapojiť aj Vy', "https://platforma.slovensko.digital/t/#{@project.project_id}", title: 'Upraviť hodnotenie', class: 'alert-link' %>.
-
-
- <% end %>
-
-
-
-
-
-
Aktuálny stav projektu
-
<%= @project.stage %>
-
-
-
Čo sa práve deje
-
<%= @project.current_status&.html_safe %>
-
-
-
-
-
-
-
Hodnotenie<% if @project.redflags_count > 0 %> <%= @project.redflags_count %> × <%= fa_icon('flag', class: 'text-danger') %><% end %>
Názov: Informačný systém Obchodného registra (IS OR)
Garant: Ministerstvo spravodlivosti SR
\n
Stručný opis: Implementovanť nový IS pre správu Obchodného registra a súvisiace opatrenia na zafektívnenie jeho procesov.
\n
Náklady na projekt: 13 250 000 EUR (s DPH, podľa vyzvania na národný projekt)
\n
Aktuálny stav projektu: Výzva na národný projekt v OPII
Čo sa práve deje:
\n
Nie sú známe žiadne plánované aktivity
Ani v ďalšej odrážke nie sú aktivity
Zhrnutie hodnotenia Red Flags: Najvýraznejším nedostatkom projektu EDUNET je nedostatočná príprava projektu, chýbajúce zhodnotenie alternatív a ekonomické zhodnotenie rôznych modelov nákupu a budovania školskej siete. Projekt je nastavený tak, že na trhu s viac ako 300 dodávateľmi sa obstarávania zúčastnili len štyria. Ministerstvo taktiež odmieta odbornú diskusiu k projektu, čo výrazne zvyšuje obavu o jeho kvalitu.
Stanovisko Slovensko.Digital: Odporúčame projekt pozastaviť a dôkladne zanalyzovať rôzne alternatívy budovania siete aj s ohľadom na podmienky na telekomunikačnom trhu.
Projekt deklaruje optimalizáciu procesov priamo súvisiacich s Obchodným registrom. \nKonkrétne bola identifikovaná zmena v rozsahu subjektov ktoré môžu zapísať spoločnosť do OR.
\n
Projekt nerieši komplexne životné situácie súvisiace s podnikaním. \nNapr. celkový priemerný čas na založenie obchodnej spoločnosti je 45 dní (viď. RZ kap. 1). Tento projekt nerieši situáciu komplexne, ale iba časť týkajúcu sa zapísania do OR - z 2 dní na “obratom”. Aj v prípade uskutočnenia cieľov projektu sa výsledný celkový čas teda zlepší najviac o 5%.
“Termínom “obratom” sa v podmienkach Obchodného registra rozumie do konca dňa, obchodný register bude aktualizovaný na dennej báze.” (podľa Štúdie uskutočniteľnosti)
\n
Štúdia uskutočniteľnosti:
\n
\n
Dôležitým výstupovým ukazovateľom projektu je zabezpečenie 100% kvality a integrity dát v obchodnom registry. (kap. 1.1)
\n
Dáta z obchodného registra budú použiteľné na právne účely on-line, čím sa eliminuje potreba výpisov z obchodného registra. (kap 1.1)
\n
\n
Nie sú známe merateľné ciele súvisiace s optimalizáciou vnútorného prostredia verejnej správy súvisiacej s agendou OR, čo je jeden z deklarovaných zámerov projektu.
\n\n
Postup dosiahnutia cieľov \n
\n
Projekt je rozdelený na dve etapy, prvá etapa sú funkcie pre ktoré nie je vyžadovaná legislatívna zmena (podľa štúdie uskutočniteľnosti). Štúdia uskutočniteľnosti obsahuje detailný harmonogram činností. \nOd iných subjektov je pri realizácii projektu závislá iba integrácia na referenčné údaje.
\n
Nie je známe, akým spôsobom bude realizované dosiahnutie cieľa “100% kvality dát v registri”, ktoré bude náročné aj vzhľadom na historické skúsenosti v tejto oblasti.
\n\n
Súlad s KRIS (nie je zatiaľ vyhodnotený)
\n
Súlad s KRIS či už ÚPVII, alebo OVM, ktoré majú byť do projektu zapojené, sme zatiaľ nevyhodnotili. \nVšetky KRIS majú do konca roka 2017 prejsť podstatnou aktualizáciou, doplnený by mal byť cieľový stav ISVS.
\n\n
Biznis prínos \n
\n
Projekt má podstatne zjednodušiť internú administratívu súvisiacu s ORSR. \nImplementácia princípu “Digital by default” v rámci interného spracovania agendy. \nV súčasnosti je podstatná časť agiend OR už podporovaná špecializovaným IS, ide teda skôr o postupné zlepšenie v tejto oblasti.
\n\n
Príspevok v informatizácii \n
\n
Súčasťou projektu je riešenie kvality údajov (cieľ - 100% správnych údajov v registri). \nOd začiatku sú podporované princípy OpenData, OpenAPI, zverejnenie právne záväzných údajov. \nProjekt počíta s integráciou na všetky registre obsahujúce všetky údaje potrebné na jednotlivé procesy OR, čím sa zabezpečí princíp 1x a dosť voči OR. \nÚdaje OR majú byť referenčné a jednoducho použiteľné pre ostatné OVM. V tejto oblasti nie je jasné rozdelenie kompetencií medzi ORSR a RPO.
\n
Podľa štúdie bude v relevantných moduloch zvážený agilný prístup vývoja a možnosť obstarať časti ako službu (a nie ako dielo).
\n
V ďalších etapách projektu treba overiť, že uvažované je používateľsky prívetivé grafické rozhranie, nie len formulárový systém.
\n\n
Štúdia uskutočniteľnosti \n
\n
Štúdia uskutočniteľnosti bola vypracovaná, bolo umožnené jej pripomienkovanie, vzhľadom na (malý) rozsah projektu obsahuje dostatočnú mieru detailov, konkrétnych cieľov a postupov. \nUvedený prehľad v súčasnosti prevádzkovaného IS a súvisiacich nákladov. \nNavrhnutý nový IS je prehľadne členený na moduly.
\n\n
Alternatívy \n
\n
V Štúdii uskutočniteľnosti je podrobne analyzovaná možnosť rozvoja súčasného IS a vybudovanie nového IS a dopady rozšírenia okruhu registrátorov obchodných spoločností. \nNie sú analyzované varianty v závislosti od spôsobu realizácie jednotlivých modulov (napr. riešenie integrácií prostredníctvom MÚK vs. integrácie priamo G2G, obstaranie niektorých komponentov v režime SaaS). \nNie sú analyzované náklady a prínosy pri realizácie “nepovinných” súčastí, napr. publikovanie profilov obchodných firiem, resp. porovnanie s už existujúcimi riešeniami (napr. v komerčnej sfére).
\n\n
Kalkulácia efektívnosti \n
\n
CBA uvádzanú v štúdii sme zatiaľ podrobne neanalyzovali. Vyzvanie na národný projekt obsahuje viaceré verzie CBA, s vzájomne nekonzistentnými hodnotami položiek. \nNiektoré položky projektu, napr. náklady na OpenData a OpenAPI - 400.000€, kalkulované náklady potrebné na integrácie G2G a BRIS - 2,2M€ sa javia ako neobvykle vysoké. \nNie je známe, akým spôsobom boli odhady nákladov na jednotlivé položky stanovené.
\n\n
Participácia na príprave projektu \n
\n
K reformnému zámeru aj štúdii uskutočniteľnosti bolo možné poslať pripomienky. \nMinisterstvo prizvalo vybrané subjekty (vrátane S.D), mohli sa vyjadriť a dať pripomienky k štúdii vo fáze draftu. \nUskutočnilo sa verejné prerokovanie štúdie, za účasti ministerky.
pripomienky k Štúdii uskutočniteľnosti a ich zapracovanie: potrebné získať od MSSR alebo ÚPVII
\n
\n
\n
Procesno organizačný audit rezortu spravodlivosti (zameraná na registráciu obchodných spoločností): potrebné získať od MSSR - podľa RZ bol vypracovaný v prvom kvartáli 2017
\n
\n
\n\n
\n Aktivity
\n
V tomto projekte už prebehli nasledovné dôležité aktivity / míľniky:
Páči sa mi, že pri väčšine hodnotení, ktoré nie sú 100% je napísané čo chýba do 100%. \nNevidím to pri hodnotení biznis prínosu. Tam mi nie je veľmi jasné prečo sú iba 3 zo 4. Je to preto, že už čosi je urobené a teda prínos nie je príliš veľký? Čo by sa mohlo doplniť, aby bol prínos väčší? Jednoducho hodnotenie biznis prínosu sa mi zdá menej jasné ako pri ostatných atribútoch.
", "hidden" => false, "user_id" => 226, "version" => 1, "avg_time" => 17, "can_edit" => false, "can_wiki" => false, "topic_id" => 4228, "username" => "vojtob", "moderator" => false, "post_type" => 1, "can_delete" => false, "created_at" => "2017-10-03T09:37:10.218Z", "deleted_at" => nil, "topic_slug" => "red-flags-is-obchodneho-registra", "updated_at" => "2017-10-03T09:37:10.218Z", "user_title" => nil, "can_recover" => false, "edit_reason" => nil, "post_number" => 2, "quote_count" => 0, "reply_count" => 0, "trust_level" => 2, "user_deleted" => false, "accepted_answer" => false, "actions_summary" => [], "avatar_template" => "/letter_avatar_proxy/v2/letter/v/3da27b/{size}.png", "display_username" => "Vojto Bálint", "hidden_reason_id" => nil, "can_accept_answer" => false, "primary_group_name" => nil, "can_unaccept_answer" => false, "incoming_link_count" => 2, "reply_to_post_number" => nil, "can_view_edit_history" => true, "primary_group_flair_url" => nil, "primary_group_flair_color" => nil, "primary_group_flair_bg_color" => nil }], "stream" => [20183, 20224] }, "posts_count" => 2, "reply_count" => 0, "topic_timer" => nil, "pinned_until" => nil, "featured_link" => nil, "draft_sequence" => nil, "last_posted_at" => "2017-10-03T09:37:10.218Z", "actions_summary" => [{ "id" => 4, "count" => 0, "hidden" => false, "can_act" => false }, { "id" => 7, "count" => 0, "hidden" => false, "can_act" => false }, { "id" => 8, "count" => 0, "hidden" => false, "can_act" => false }], "pinned_globally" => false, "timeline_lookup" => [[1, 26], [2, 24]], "suggested_topics" => [{ "id" => 4237, "slug" => "red-flags-centralny-ekonomicky-system-ces", "tags" => ["ces", "mfsr"], "liked" => nil, "title" => "Red Flags: Centrálny ekonomický systém (CES)", "views" => 124, "bumped" => true, "closed" => false, "pinned" => false, "unseen" => false, "posters" => [{ "user" => { "id" => 3, "username" => "janhargas", "avatar_template" => "/user_avatar/platforma.slovensko.digital/janhargas/{size}/16_1.png" }, "extras" => "latest single", "description" => "Original Poster, Most Recent Poster" }], "visible" => true, "archived" => false, "unpinned" => nil, "archetype" => "regular", "bumped_at" => "2017-10-02T23:15:04.714Z", "image_url" => "//platforma-slovensko-digital-uploads.s3-eu-central-1.amazonaws.com/optimized/2X/9/98e99022eee3c425dd06555c953642497f5ab1e3_1_690x419.png", "bookmarked" => nil, "created_at" => "2017-10-02T23:07:25.117Z", "like_count" => 0, "category_id" => 43, "fancy_title" => "Red Flags: Centrálny ekonomický systém (CES)", "posts_count" => 1, "reply_count" => 0, "featured_link" => nil, "last_posted_at" => "2017-10-02T23:07:25.300Z", "highest_post_number" => 1 }, { "id" => 4262, "slug" => "red-flags-elektronicke-sluzby-narodneho-bezpecnostneho-uradu", "tags" => ["redflags", "nbú"], "liked" => nil, "title" => "Red Flags: Elektronické služby Národného bezpečnostného úradu", "views" => 101, "bumped" => true, "closed" => false, "pinned" => false, "unseen" => false, "posters" => [{ "user" => { "id" => 7, "username" => "Lubor", "avatar_template" => "/letter_avatar_proxy/v2/letter/l/96bed5/{size}.png" }, "extras" => "latest single", "description" => "Original Poster, Most Recent Poster" }], "visible" => true, "archived" => false, "unpinned" => nil, "archetype" => "regular", "bumped_at" => "2017-10-09T07:19:23.747Z", "image_url" => "//platforma-slovensko-digital-uploads.s3-eu-central-1.amazonaws.com/original/2X/f/f0fed63872490f19a395d13b1bea66bee20ddbc1.PNG", "bookmarked" => nil, "created_at" => "2017-10-09T07:19:23.412Z", "like_count" => 0, "category_id" => 43, "fancy_title" => "Red Flags: Elektronické služby Národného bezpečnostného úradu", "posts_count" => 1, "reply_count" => 0, "featured_link" => nil, "last_posted_at" => "2017-10-09T07:19:23.747Z", "highest_post_number" => 1 }, { "id" => 4035, "slug" => "red-flags-elektronicke-sluzby-statneho-fondu-rozvoja-byvania-es-sfrb", "tags" => ["mdvrr", "šfrb", "redflags"], "liked" => nil, "title" => "Red Flags: Elektronické služby Štátneho fondu rozvoja bývania (ES ŠFRB)", "views" => 319, "bumped" => true, "closed" => false, "pinned" => false, "unseen" => false, "posters" => [{ "user" => { "id" => 1, "username" => "jsuchal", "avatar_template" => "/user_avatar/platforma.slovensko.digital/jsuchal/{size}/15_1.png" }, "extras" => nil, "description" => "Original Poster" }, { "user" => { "id" => 1334, "username" => "Tomas_Pavelka", "avatar_template" => "/letter_avatar_proxy/v2/letter/t/48db29/{size}.png" }, "extras" => "latest", "description" => "Most Recent Poster" }], "visible" => true, "archived" => false, "unpinned" => nil, "archetype" => "regular", "bumped_at" => "2017-09-04T13:08:23.895Z", "image_url" => "//platforma-slovensko-digital-uploads.s3-eu-central-1.amazonaws.com/optimized/2X/2/29a8e3cb1cfd3b376a3f866bc9888fbd84fd7452_1_446x500.PNG", "bookmarked" => nil, "created_at" => "2017-08-07T14:03:35.245Z", "like_count" => 2, "category_id" => 43, "fancy_title" => "Red Flags: Elektronické služby Štátneho fondu rozvoja bývania (ES ŠFRB)", "posts_count" => 2, "reply_count" => 0, "featured_link" => nil, "last_posted_at" => "2017-08-23T18:12:11.332Z", "highest_post_number" => 4 }, { "id" => 4236, "slug" => "red-flags-komplexne-zvysenie-kvality-procesov-v-podmienkach-zboru-vazenskej-a-justicnej-straze", "tags" => ["redflags"], "liked" => nil, "title" => "Red Flags: Komplexné zvýšenie kvality procesov v podmienkach Zboru väzenskej a justičnej stráže", "views" => 107, "bumped" => true, "closed" => false, "pinned" => false, "unseen" => false, "posters" => [{ "user" => { "id" => 1542, "username" => "Michal_Haman", "avatar_template" => "/user_avatar/platforma.slovensko.digital/michal_haman/{size}/1827_1.png" }, "extras" => "latest single", "description" => "Original Poster, Most Recent Poster" }], "visible" => true, "archived" => false, "unpinned" => nil, "archetype" => "regular", "bumped_at" => "2017-10-02T21:51:55.162Z", "image_url" => "//platforma-slovensko-digital-uploads.s3-eu-central-1.amazonaws.com/original/2X/f/f5267b6a7df2234e30b3877e9a9b74b988be5a6c.png", "bookmarked" => nil, "created_at" => "2017-10-02T21:51:54.195Z", "like_count" => 0, "category_id" => 43, "fancy_title" => "Red Flags: Komplexné zvýšenie kvality procesov v podmienkach Zboru väzenskej a justičnej stráže", "posts_count" => 1, "reply_count" => 0, "featured_link" => nil, "last_posted_at" => "2017-10-02T21:51:55.162Z", "highest_post_number" => 1 }, { "id" => 4284, "slug" => "red-flags-informacny-system-centra-pravnej-pomoci", "tags" => ["redflags", "mssr"], "liked" => nil, "title" => "Red Flags: Informačný systém Centra právnej pomoci", "views" => 61, "bumped" => true, "closed" => false, "pinned" => false, "unseen" => false, "posters" => [{ "user" => { "id" => 7, "username" => "Lubor", "avatar_template" => "/letter_avatar_proxy/v2/letter/l/96bed5/{size}.png" }, "extras" => "latest single", "description" => "Original Poster, Most Recent Poster" }], "visible" => true, "archived" => false, "unpinned" => nil, "archetype" => "regular", "bumped_at" => "2017-10-16T05:24:46.270Z", "image_url" => "//platforma-slovensko-digital-uploads.s3-eu-central-1.amazonaws.com/optimized/2X/5/5d559a19038a394b4fbe4386620a10e4bee75f4e_1_690x427.PNG", "bookmarked" => nil, "created_at" => "2017-10-16T00:26:01.070Z", "like_count" => 0, "category_id" => 43, "fancy_title" => "Red Flags: Informačný systém Centra právnej pomoci", "posts_count" => 1, "reply_count" => 0, "featured_link" => nil, "last_posted_at" => "2017-10-16T00:26:01.236Z", "highest_post_number" => 1 }], "participant_count" => 2, "highest_post_number" => 2, "message_bus_last_id" => 19, "pm_with_non_human_user" => false } }
end
diff --git a/spec/features/administration_spec.rb b/spec/features/administration_spec.rb
index 13851af..45bedf0 100644
--- a/spec/features/administration_spec.rb
+++ b/spec/features/administration_spec.rb
@@ -7,7 +7,7 @@
authorize_as_admin
visit admin_root_path
- expect { click_on 'Synchronize' }.to have_enqueued_job(SyncCategoryTopicsJob)
+ expect { click_on 'Synchronize' }.to have_enqueued_job(SyncAllTopicsJob)
end
def see_all_pages
@@ -29,8 +29,8 @@ def see_all_pages
scenario 'As admin I want to see all project pages' do
create(:page, :published)
create(:page, :unpublished)
- create(:project, page: Page.first)
- create(:project, page: Page.second)
+ create(:project)
+ create(:project)
see_all_pages
end
@@ -44,12 +44,11 @@ def preview_page
end
scenario 'As admin I want to preview page' do
- create(:page)
- preview_page
- end
+ page_to_preview = create(:page)
+ revision = page_to_preview.revisions.first
+
+ SyncRevisionJob.perform_now(revision)
- scenario 'As admin I want to preview project page' do
- create(:page)
preview_page
end
@@ -65,13 +64,23 @@ def publish_page
end
scenario 'As admin I want to publish page' do
- create(:page, :unpublished)
- publish_page
- end
+ allow(UpdateMultipleSheetColumnsJob).to receive(:perform_later)
+ allow(ExportTopicIntoSheetJob).to receive(:perform_later)
+
+ page_to_preview = create(:page, :unpublished)
+ project = create(:project)
+ revision = page_to_preview.revisions.first
+
+ phase_revision = nil
+ project.phases.each do |phase|
+ phase_revision = phase.revisions.find_or_initialize_by(revision_id: revision&.id)
+ end
+
+ if phase_revision.present?
+ phase_revision.load_from_data(revision&.raw)
+ phase_revision.save!
+ end
- scenario 'As admin I want to publish project page' do
- create(:page, :unpublished)
- create(:project, page: Page.first)
publish_page
end
@@ -87,13 +96,22 @@ def unpublish_page
end
scenario 'As admin I want to unpublish page' do
- create(:page, :published)
- unpublish_page
- end
+ allow(UpdateMultipleSheetColumnsJob).to receive(:perform_later)
+
+ page_to_preview = create(:page, :published)
+ project = create(:project)
+ revision = page_to_preview.revisions.first
+
+ phase_revision = nil
+ project.phases.each do |phase|
+ phase_revision = phase.revisions.find_or_initialize_by(revision_id: revision&.id)
+ end
+
+ if phase_revision.present?
+ phase_revision.load_from_data(revision&.raw)
+ phase_revision.save!
+ end
- scenario 'As admin I want to unpublish project page' do
- create(:page, :published)
- create(:project, page: Page.first)
unpublish_page
end
@@ -119,90 +137,75 @@ def see_all_revisions
end
scenario 'As admin I want to see all revisions of project page' do
- create(:page, :published)
- create(:project, page: Page.first)
- create(:revision, page: Page.first)
+ page = create(:page, :published)
+ create(:project)
+ create(:revision, page: page)
+
see_all_revisions
end
- def preview_non_latest_revision
+ def preview_non_latest_revision(version)
authorize_as_admin
visit admin_root_path
-
click_on Page.first.id
-
- within :id, dom_id(Revision.first) do
+ within :id, dom_id(Revision.find_by_version(version)) do
expect(page).not_to have_content('published')
expect(page).not_to have_content('latest')
-
- click_on 'Preview'
end
end
scenario 'As admin I want to preview non-latest page revision' do
- create(:page, :unpublished)
- create(:revision, page: Page.first)
- preview_non_latest_revision
+ page = create(:page, :unpublished)
+ project = create(:project)
+
+ older_revision = create(:revision, page: page, version: 1)
+ create_project_revision(project, older_revision)
+
+ latest_revision = create(:revision, page: page, version: 2)
+ create_project_revision(project, latest_revision)
+
+ preview_non_latest_revision(older_revision.version)
end
- scenario 'As admin I want to preview non-latest project page revision' do
- create(:page, :unpublished)
- create(:project, page: Page.first)
- create(:revision, page: Page.first)
- preview_non_latest_revision
+ def create_project_revision(project, revision)
+ phase_revision = nil
+ project.phases.each do |phase|
+ phase_revision = phase.revisions.find_or_initialize_by(revision_id: revision&.id)
+ end
+
+ if phase_revision.present?
+ phase_revision.load_from_data(revision&.raw)
+ phase_revision.save!
+ end
end
- def publish_non_latest_revision
+ def publish_non_latest_revision(version)
authorize_as_admin
visit admin_root_path
-
click_on Page.first.id
- within :id, dom_id(Revision.first) do
+ within :id, dom_id(Revision.find_by_version(version)) do
expect(page).not_to have_content('published')
expect(page).not_to have_content('latest')
-
click_on 'Publish'
end
- within :id, dom_id(Revision.first) do
+ within :id, dom_id(Revision.find_by_version(version)) do
expect(page).to have_content('published')
end
end
scenario 'As admin I want to publish non-latest page revision' do
- create(:page, :unpublished)
- create(:revision, page: Page.first)
- publish_non_latest_revision
- end
+ page = create(:page, :unpublished)
+ phase = create(:phase)
- scenario 'As admin I want to publish non-latest project page revision' do
- create(:page, :unpublished)
- create(:project, page: Page.first)
- create(:revision, page: Page.first)
- publish_non_latest_revision
- end
-
- context 'project page specific features' do
- scenario 'As admin I want to edit project category' do
- create(:project)
-
- authorize_as_admin
- visit admin_root_path
+ older_revision = create(:revision, page: page, version: 1)
+ create(:phase_revision, revision: older_revision, phase: phase)
- click_on Page.first.id
+ latest_revision = create(:revision, page: page, version: 2)
+ create(:phase_revision, revision: latest_revision, phase: phase)
- within 'h4' do
- expect(page).to have_content('boring')
- end
-
- choose 'good'
- click_on 'Update'
-
- within 'h4' do
- expect(page).to have_content('good')
- end
- end
+ publish_non_latest_revision(1)
end
private
diff --git a/spec/jobs/sync_all_topics_job_spec.rb b/spec/jobs/sync_all_topics_job_spec.rb
new file mode 100644
index 0000000..63543f9
--- /dev/null
+++ b/spec/jobs/sync_all_topics_job_spec.rb
@@ -0,0 +1,85 @@
+require 'rails_helper'
+
+RSpec.describe SyncAllTopicsJob, type: :job do
+ include ActiveJob::TestHelper
+
+ subject(:job) { described_class.perform_later }
+
+ let(:sheets_service) { instance_double('GoogleApiService') }
+ let(:response_values) do
+ [
+ [],
+ [],
+ ['Projekt', 'Projekt ID', 'Platforma', 'ID draft prípravy', 'ID prípravy', 'ID draft produktu', 'ID produktu'],
+ ['Projekt1', 'ABC1', '', 'ABC1', 'ABC1', 'ABC1', 'ABC1'],
+ ['Projekt2', 'ABC2', 'http://google.com', 'ABC2', 'ABC2', 'ABC2', 'ABC2']
+ ]
+ end
+
+ let(:indices) { { 'Projekt' => 0, 'Projekt ID' => 1, 'Platforma' => 2, 'ID draft prípravy' => 3, 'ID prípravy' => 4, 'ID draft produktu' => 5, 'ID produktu' => 6 } }
+
+ before do
+ google_sheets_service = instance_double(Google::Apis::SheetsV4::SheetsService)
+ allow(GoogleApiService).to receive(:get_sheets_service).and_return(google_sheets_service)
+ allow(google_sheets_service).to receive(:get_spreadsheet_values).with(ENV.fetch('GOOGLE_SHEET_ID'), 'A:Z').and_return(OpenStruct.new(values: response_values))
+ end
+
+ it 'queues the job' do
+ expect { job }.to have_enqueued_job(described_class)
+ .on_queue("default")
+ end
+
+ it 'executes perform' do
+ described_class.perform_now
+ expect(ActiveJob::Base.queue_adapter.enqueued_jobs.size).to eq 4
+ end
+
+ context 'when mandatory columns are missing' do
+ let(:response_values) do
+ [
+ [],
+ [],
+ ['Projekt'],
+ ['Projekt1', 'ABC1', '', 'ABC1', 'ABC1', 'ABC1', 'ABC1'],
+ ['Projekt2', 'ABC2', 'http://google.com', 'ABC2', 'ABC2', 'ABC2', 'ABC2']
+ ]
+ end
+
+ it 'raises an ArgumentError' do
+ expect { described_class.perform_now }
+ .to raise_error(ArgumentError, "Could not find required columns in the spreadsheet.")
+ end
+ end
+
+ context 'when spreadsheet values are missing' do
+ let(:response_values) do
+ [
+ [],
+ [],
+ ['Projekt', 'Projekt ID', 'Platforma', 'ID draft prípravy', 'ID prípravy', 'ID draft produktu', 'ID produktu']
+ ]
+ end
+
+ it 'does not enqueue any jobs' do
+ described_class.perform_now
+ expect(ActiveJob::Base.queue_adapter.enqueued_jobs.size).to eq 0
+ end
+ end
+
+ context 'when Platforma is empty for any project' do
+ let(:response_values) do
+ [
+ [],
+ [],
+ ['Projekt', 'Projekt ID', 'Platforma', 'ID draft prípravy', 'ID prípravy', 'ID draft produktu', 'ID produktu'],
+ ['Projekt1', 'ABC1', '', 'ABC1', '', 'ABC1', ''],
+ ['Projekt2', 'ABC2', 'http://google.com', 'ABC2', 'ABC2', 'ABC2', 'ABC2']
+ ]
+ end
+
+ it 'enqueues SyncGoogleDocumentJob' do
+ described_class.perform_now
+ expect(ActiveJob::Base.queue_adapter.enqueued_jobs.map { |j| j[:job] }).to include(SyncGoogleDocumentJob)
+ end
+ end
+end
diff --git a/spec/jobs/sync_category_topics_job_spec.rb b/spec/jobs/sync_category_topics_job_spec.rb
index de26ce3..64a3164 100644
--- a/spec/jobs/sync_category_topics_job_spec.rb
+++ b/spec/jobs/sync_category_topics_job_spec.rb
@@ -6,9 +6,9 @@
it 'schedules topic sync jobs for all topics in category', vcr: true do
subject.perform('red-flags', sync_topic_job: sync_topic_job)
- expect(sync_topic_job).to have_received(:perform_later).with(4034)
- expect(sync_topic_job).to have_received(:perform_later).with(4334)
- expect(sync_topic_job).to have_received(:perform_later).with(4035)
+ expect(sync_topic_job).to have_received(:perform_later).with(nil, 4034)
+ expect(sync_topic_job).to have_received(:perform_later).with(nil, 4334)
+ expect(sync_topic_job).to have_received(:perform_later).with(nil, 4035)
end
it 'schedules next topic page when listing too long', vcr: true do
diff --git a/spec/jobs/sync_google_document_job_spec.rb b/spec/jobs/sync_google_document_job_spec.rb
new file mode 100644
index 0000000..cdf9773
--- /dev/null
+++ b/spec/jobs/sync_google_document_job_spec.rb
@@ -0,0 +1,69 @@
+require 'rails_helper'
+
+RSpec.describe SyncGoogleDocumentJob, type: :job do
+ include ActiveJob::TestHelper
+
+ subject(:job) { described_class.perform_later(project_name, project_id, google_document_id, page_id, page_type) }
+
+ let(:project_name) { 'Project1' }
+ let(:project_id) { 'ABC1' }
+ let(:google_document_id) { 'DOC1' }
+ let(:page_id) { 'PAGE1' }
+ let(:page_type) { 0 }
+ let(:drive_service) { instance_double(Google::Apis::DriveV3::DriveService) }
+ let(:revisions_count) { 1 }
+ let(:document) { instance_double('Google::Apis::DocsV1::Document') }
+ let(:parser_service) { instance_double('DocumentParserService') }
+ let(:html_content) { 'Content' }
+ let(:parsed_hash) { {content: 'Parsed content'} }
+ let(:page) { create(:page) }
+ let(:revision) { create(:revision) }
+ let(:revision) { create(:revision) }
+
+ before do
+ allow(Page).to receive_message_chain(:find_or_create_by!).and_return(page)
+ allow(Project).to receive_message_chain(:find_or_create_by!).and_return(instance_double('Project'))
+ allow(GoogleApiService).to receive(:get_drive_service).and_return(drive_service)
+ allow(drive_service).to receive(:list_revisions).and_return(instance_double(Google::Apis::DriveV3::RevisionList, revisions: Array.new(revisions_count)))
+ allow(GoogleApiService).to receive(:get_document).and_return(document)
+ allow(DocumentParserService).to receive(:new).with(document).and_return(parser_service)
+ allow(parser_service).to receive(:to_html).and_return(html_content)
+ allow(parser_service).to receive(:to_hash).with(html_content).and_return(revision.raw)
+ allow(page).to receive(:revisions).and_return(Revision)
+ allow(Revision).to receive(:find_or_initialize_by).and_return(revision)
+ allow(revision.phase_revision).to receive(:load_ratings).with(revision.raw)
+ end
+
+ it 'queues the job' do
+ expect { job }.to have_enqueued_job(described_class)
+ .on_queue("default")
+ .with(project_name, project_id, google_document_id, page_id, page_type)
+ .at(:no_wait)
+ end
+
+ context 'when performing the job' do
+ it 'invokes methods in correct sequence' do
+ described_class.perform_now(project_name, project_id, google_document_id, page_id, page_type)
+
+ expect(GoogleApiService).to have_received(:get_drive_service)
+ expect(drive_service).to have_received(:list_revisions)
+ expect(GoogleApiService).to have_received(:get_document)
+ expect(DocumentParserService).to have_received(:new).with(document)
+ expect(parser_service).to have_received(:to_html)
+ expect(parser_service).to have_received(:to_hash).with(html_content)
+ expect(page).to have_received(:revisions)
+ expect(Revision).to have_received(:find_or_initialize_by)
+ end
+ end
+
+ context 'when GoogleApiService raises error' do
+ before do
+ allow(GoogleApiService).to receive(:get_drive_service).and_raise(StandardError.new)
+ end
+
+ it 'raises an exception' do
+ expect { described_class.perform_now(project_name, project_id, google_document_id, page_id, page_type) }
+ .to raise_error(StandardError)
+ end
+ end
+end
\ No newline at end of file
diff --git a/spec/jobs/sync_one_topic_job_spec.rb b/spec/jobs/sync_one_topic_job_spec.rb
new file mode 100644
index 0000000..52d5c65
--- /dev/null
+++ b/spec/jobs/sync_one_topic_job_spec.rb
@@ -0,0 +1,74 @@
+require 'rails_helper'
+
+RSpec.describe SyncOneTopicJob, type: :job do
+ include ActiveJob::TestHelper
+
+ subject(:job) { described_class.perform_later(page_id) }
+
+ let(:page_id) { 'ABC1' }
+ let(:sheets_service) { instance_double('GoogleApiService') }
+ let(:response_values) do
+ [
+ [],
+ [],
+ ['Projekt', 'Projekt ID', 'Platforma', 'ID draft prípravy', 'ID prípravy', 'ID draft produktu', 'ID produktu'],
+ ['Projekt1', 'ABC1', '', 'ABC1', 'ABC1', 'ABC1', 'ABC1'],
+ ['Projekt2', 'ABC2', 'http://google.com', 'ABC2', 'ABC2', 'ABC2', 'ABC2']
+ ]
+ end
+
+ let(:row) { ['Projekt1', 'ABC1', '', 'ABC1', 'ABC1', 'ABC1', 'ABC1'] }
+
+ let(:indices) { { 'Projekt' => 0, 'Projekt ID' => 1, 'Platforma' => 2, 'ID draft prípravy' => 3, 'ID prípravy' => 4, 'ID draft produktu' => 5, 'ID produktu' => 6 } }
+
+ before do
+ google_sheets_service = instance_double(Google::Apis::SheetsV4::SheetsService)
+ allow(GoogleApiService).to receive(:get_sheets_service).and_return(google_sheets_service)
+ allow(google_sheets_service).to receive(:get_spreadsheet_values).with(ENV.fetch('GOOGLE_SHEET_ID'), 'A:Z').and_return(OpenStruct.new(values: response_values))
+ end
+
+ it 'queues the job' do
+ expect { job }.to have_enqueued_job(described_class)
+ .on_queue("default")
+ .with(page_id)
+ end
+
+ it 'executes perform' do
+ described_class.perform_now(page_id)
+ expect(ActiveJob::Base.queue_adapter.enqueued_jobs.map { |j| j[:job] }).to include(SyncGoogleDocumentJob)
+ end
+
+ context 'when performing the job' do
+ it 'fetches spreadsheet values, finds indices and processes row' do
+ expect_any_instance_of(SyncOneTopicJob).to receive(:find_indices).with(OpenStruct.new(values: response_values).values[2]).and_return(indices)
+ expect_any_instance_of(SyncOneTopicJob).to receive(:process_row).with(row, indices, page_id)
+
+ described_class.perform_now(page_id)
+ end
+ end
+
+ context 'when no row matches the given page_id' do
+ let(:page_id) { 'Prod2' }
+
+ it 'does not attempt to process the row' do
+ expect_any_instance_of(SyncOneTopicJob).not_to receive(:process_row)
+
+ described_class.perform_now(page_id)
+ end
+ end
+
+ context 'when mandatory columns are missing' do
+ let(:response_values) do
+ [
+ ['Projekt'],
+ ['Projekt1', 'ABC1', '', 'ABC1', 'ABC1', 'ABC1', 'ABC1'],
+ ['Projekt2', 'ABC2', 'http://google.com', 'ABC2', 'ABC2', 'ABC2', 'ABC2']
+ ]
+ end
+
+ it 'raises an ArgumentError' do
+ expect { described_class.perform_now(page_id) }
+ .to raise_error(ArgumentError, "Could not find required columns in the spreadsheet.")
+ end
+ end
+end
\ No newline at end of file
diff --git a/spec/jobs/sync_project_job_spec.rb b/spec/jobs/sync_project_job_spec.rb
deleted file mode 100644
index 896ac9b..0000000
--- a/spec/jobs/sync_project_job_spec.rb
+++ /dev/null
@@ -1,5 +0,0 @@
-require 'rails_helper'
-
-RSpec.describe SyncProjectJob, type: :job do
- pending "add some examples to (or delete) #{__FILE__}"
-end
diff --git a/spec/jobs/sync_revision_job_spec.rb b/spec/jobs/sync_revision_job_spec.rb
index c8192a5..98c0ed7 100644
--- a/spec/jobs/sync_revision_job_spec.rb
+++ b/spec/jobs/sync_revision_job_spec.rb
@@ -9,11 +9,12 @@
end
it 'parses project metadata from revision' do
- revision = create(:revision)
+ page_to_preview = create(:page)
+ revision = page_to_preview.revisions.first
subject.perform(revision)
- snapshot = ProjectRevision.first
+ snapshot = PhaseRevision.last
expect(snapshot).to have_attributes(
title: 'IS Obchodného registra',
@@ -33,25 +34,4 @@
expect(ratings['Participácia na príprave projektu'].score).to eq(4)
expect(ratings['Biznis prínos'].score).to eq(0)
end
-
- it 'ignores pages from unknown category' do
- revision = create(:revision)
- revision.raw['category_id'] = 123
- revision.save!
-
- subject.perform(revision)
-
- expect(ProjectRevision.count).to eq(0)
- end
-
- it 'adds calculated total and max score to revision' do
- revision = create(:revision)
-
- subject.perform(revision)
-
- snapshot = ProjectRevision.first
-
- expect(snapshot.total_score).to eq(6)
- expect(snapshot.maximum_score).to eq(12)
- end
end
diff --git a/spec/jobs/sync_topic_job_spec.rb b/spec/jobs/sync_topic_job_spec.rb
index f13105c..ea5c97a 100644
--- a/spec/jobs/sync_topic_job_spec.rb
+++ b/spec/jobs/sync_topic_job_spec.rb
@@ -2,7 +2,8 @@
RSpec.describe SyncTopicJob, type: :job do
it 'loads current version of topic into page and revision', vcr: true do
- subject.perform(4034)
+ project = create(:project)
+ subject.perform(project.id ,4034)
page = Page.first
diff --git a/spec/jobs/update_multiple_sheet_columns_job_spec.rb b/spec/jobs/update_multiple_sheet_columns_job_spec.rb
new file mode 100644
index 0000000..f4ea84d
--- /dev/null
+++ b/spec/jobs/update_multiple_sheet_columns_job_spec.rb
@@ -0,0 +1,33 @@
+require 'rails_helper'
+
+RSpec.describe UpdateMultipleSheetColumnsJob, type: :job do
+ let(:page_id) { 'some_page_id' }
+ let(:updates) do
+ [
+ { column_names: ['name1', 'name2'], page_type: 'type1', published_value: 'val1' },
+ { column_names: ['name3', 'name4'], page_type: 'type2', published_value: 'val2' }
+ ]
+ end
+
+ before do
+ allow(UpdateSheetValueJob).to receive(:perform_now)
+ end
+
+ it 'tasks are enqueued and update is performed' do
+ described_class.perform_now(page_id, updates)
+
+ expect(UpdateSheetValueJob).to have_received(:perform_now).with(
+ page_id,
+ updates[0][:column_names],
+ updates[0][:page_type],
+ updates[0][:published_value]
+ )
+ expect(UpdateSheetValueJob).to have_received(:perform_now).with(
+ page_id,
+ updates[1][:column_names],
+ updates[1][:page_type],
+ updates[1][:published_value]
+ )
+ expect(UpdateSheetValueJob).to have_received(:perform_now).twice
+ end
+end
\ No newline at end of file
diff --git a/spec/jobs/update_sheet_value_job_spec.rb b/spec/jobs/update_sheet_value_job_spec.rb
new file mode 100644
index 0000000..a557ddc
--- /dev/null
+++ b/spec/jobs/update_sheet_value_job_spec.rb
@@ -0,0 +1,70 @@
+require 'rails_helper'
+
+RSpec.describe UpdateSheetValueJob, type: :job do
+ include ActiveJob::TestHelper
+
+ let(:page_id) { 'Prod1' }
+ let(:column_names) { { 'topic' => 'ID prípravy', 'product' => 'ID produktu' } }
+ let(:page_type) { 'product' }
+ let(:published_value) { 'DraftProd1' }
+ let(:response_values) do
+ OpenStruct.new(values: [
+ [],
+ [],
+ ['Projekt', 'Projekt ID', 'Platforma', 'ID draft prípravy', 'ID prípravy', 'ID draft produktu', 'ID produktu'],
+ ['Projekt1', 'ABC1', '', 'ABC1', 'ABC1', 'ABC1', 'ABC1'],
+ ['Projekt2', 'ABC2', 'http://google.com', 'ABC2', 'ABC2', 'ABC2', 'ABC2']
+ ])
+ end
+ let(:header_row) { response_values.values[2] }
+ let(:indices) { { 'ID prípravy' => 4, 'ID produktu' => 6 } }
+ let(:sheets_service) { instance_double(Google::Apis::SheetsV4::SheetsService) }
+
+ before do
+ allow(GoogleApiService).to receive(:get_sheets_service).and_return(sheets_service)
+ allow(sheets_service).to receive(:get_spreadsheet_values).with(ENV['GOOGLE_SHEET_ID'], 'A:Z').and_return(response_values)
+ allow_any_instance_of(UpdateSheetValueJob).to receive(:find_indices).and_return(indices)
+ allow_any_instance_of(UpdateSheetValueJob).to receive(:find_row_index).and_return(0)
+ allow(sheets_service).to receive(:update_spreadsheet_value)
+ end
+
+ context 'when performing the job' do
+ let(:instance) { described_class.new }
+
+ before do
+ allow(UpdateSheetValueJob).to receive(:new).and_return(instance)
+ allow(instance).to receive(:find_indices).and_call_original
+ allow(instance).to receive(:find_row_index).and_return(3)
+ end
+
+ it 'fetches spreadsheet values, finds indices, finds row, handles row and updates sheet' do
+ instance.perform(page_id, column_names, page_type, published_value)
+
+ expect(GoogleApiService).to have_received(:get_sheets_service)
+ expect(sheets_service).to have_received(:get_spreadsheet_values).with(ENV['GOOGLE_SHEET_ID'], 'A:Z')
+ expect(instance).to have_received(:find_indices).with(header_row)
+ expect(instance).to have_received(:find_row_index).with(response_values.values[3..-1], indices, page_id)
+ expect(sheets_service).to have_received(:update_spreadsheet_value)
+ end
+ end
+
+ context 'when no matching column for page type' do
+ let(:column_names) { {} }
+
+ it 'raises an ArgumentError' do
+ expect { described_class.perform_now(page_id, column_names, page_type, published_value) }.to raise_error(ArgumentError, "No matching column for page type.")
+ end
+ end
+
+ context 'when no matching row for page id' do
+ let(:page_id) { 'nonexistent' }
+
+ before do
+ allow_any_instance_of(UpdateSheetValueJob).to receive(:find_row_index).and_return(nil)
+ end
+
+ it 'raises an ArgumentError' do
+ expect { described_class.perform_now(page_id, column_names, page_type, published_value) }.to raise_error(ArgumentError, "No data found for the given page_id in the spreadsheet. ID may not match or is not in string format.")
+ end
+ end
+end
\ No newline at end of file
"
+ elsif text_content.downcase.include?('aktivity')
+ icon = "
"
+ end
+ "
' * filled_stars + '
' * grey_stars
+ end
+
+ def parse_inline_object(inline_object)
+ if inline_object.inline_object_properties
+ embedded_object = inline_object.inline_object_properties.embedded_object
+ if embedded_object&.image_properties
+ "
+ 
+![\":triangular_flag_on_post:\"](\"//platforma.slovensko.digital/images/emoji/twitter/triangular_flag_on_post.png?v=5\" "\\":triangular_flag_on_post:\\"")
![\":star:\"](\"//platforma.slovensko.digital/images/emoji/twitter/star.png?v=5\" "\\":star:\\"")
![\":grey_star:\"](\"//platforma-slovensko-digital-uploads.s3-eu-central-1.amazonaws.com/original/2X/b/bdd2e11053ea53c9b119412c78ec0994497635b3.png?v=5\" "\\":grey_star:\\"")
![\"Capture\"](\"//platforma-slovensko-digital-uploads.s3-eu-central-1.amazonaws.com/original/2X/9/9d20430e2999f9b8b4213e379807a55c882df401.PNG\")
![\"Capture\"](\"//platforma-slovensko-digital-uploads.s3-eu-central-1.amazonaws.com/original/2X/2/2f03dd98d3c8fdd5ad13f26a7a1d56811b9dc2f6.PNG\")
![\":file_folder:\"](\"//platforma.slovensko.digital/images/emoji/twitter/file_folder.png?v=5\" "\\":file_folder:\\"")
Dokumenty![\":clock2:\"](\"//platforma.slovensko.digital/images/emoji/twitter/clock2.png?v=5\" "\\":clock2:\\"")
Aktivity