Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$govuk-assets-path sa neda overridovat #104

Open
thebrownfox opened this issue Aug 8, 2019 · 4 comments
Open

$govuk-assets-path sa neda overridovat #104

thebrownfox opened this issue Aug 8, 2019 · 4 comments

Comments

@thebrownfox
Copy link

Snažím sa použiť npm balík a importovať scss, tak ako odporúčajú v gov.uk

$govuk-assets-path: '/assets/';
@import "node_modules/navody-digital-frontend/all.scss";

avšak, url v takomto tvare zabraňujú jeho použitiu

$icon-pencil: url("../../../assets/images/icon-pencil.svg");

Lebo použitie .. je velmi nedeterministické

/home/foxie/Dokumenty/Code/SD/assets/images/icon-check.svg: ENOENT: no such file or directory, open '/home/foxie/Dokumenty/Code/SD/assets/images/icon-check.svg'
@eronisko
Copy link

eronisko commented Aug 9, 2019

Ahoj @thefoxie. Prestali sme pouzivat govuk-image-url helpre, lebo sa mi nepodarilo rozbehat dynamicke urls v railsovskej asset pipeline. Pouzivame namiesto toho resolve-url-loader vo webpackeri: https://github.com/slovensko-digital/navody.digital/blob/4624599ffddc9c8e3204e75bbe96ed6cf068a00a/config/webpack/environment.js. Nie je to idealny stav, ale zatial je nasa rails appka jedinym konzumentom.

Inak, s tento package sa zatial udpatuje celkom divoko, planujes s nim robit nejaku apku?

@eronisko eronisko changed the title Nedá sa vycentrovať [npm package] $govuk-assets-path sa neda overridovat Aug 9, 2019
@thebrownfox
Copy link
Author

@eronisko dokoncujem lepsiesluzby.sk, ktore sa zacali robit na hackatone a chalani to vlozili dovnutra ako .njk, takze ak sa chcem dostat k zvysku (njk, ktore to pouziva), tak ho musim pouzit (ten balik). Uz mi to funguje, len som tym zabil dost casu. Potom repo s tymto projektom pojde priamo pod SD?

@eronisko
Copy link

eronisko commented Aug 9, 2019

@thefoxie repo s projektom lepsiesluzby?

@thebrownfox
Copy link
Author

@thefoxie repo s projektom lepsiesluzby?

@eronisko ano. Ale to je asi skor otazka na PM. Ja len, ze ci by sa dal presunut ten projekt pod repozitare SD, aby to bolo public a bolo jasne o co ide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants