Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vytvorit input na rodne cislo #101

Open
pomali opened this issue Jun 13, 2019 · 4 comments
Open

Vytvorit input na rodne cislo #101

pomali opened this issue Jun 13, 2019 · 4 comments

Comments

@pomali
Copy link
Collaborator

pomali commented Jun 13, 2019

Rodne cislo ma aj jemnu validaciu zabudovanu, takze mozno by dalo zmysel urobit komponent ktory bude vpodstate text input, ale bude mat hint o tom ze si asi urobil preklep

@jsuchal
Copy link
Member

jsuchal commented Jul 2, 2019

Dobry napad. Dokonca sme to uz par krat aj potrebovali. Za mna go.

@tajovic
Copy link

tajovic commented Jul 31, 2019

Z UX pohladu navrhujem z toho spravit type number aby tam ludia nepisali nic ine ako cislo (plus to ukazalo iba cisla na virtualnej klavesnici) a lomitko sa tam prida automaticky ked tam bude napisanych 6 znakoch.

@pomali
Copy link
Collaborator Author

pomali commented Aug 1, 2019

Zatial som implementoval rodne cislo iba ako hint, ktory interne vymazava lomitko. (PR #102 )
Problem je podla mna, ze ak neviem 100% inputov ktore do daneho formularu mozu ist tak nevieme povedat, ze takyto input nepokazi formular pre niekoho v okrajovom pripade.

Napriklad ludia z cudzich krajin alebo ludia narodeni pred rokom 1954 kedy sa menil format RC, ti mozno mozu pouzit rovnake formulare ako v beznom pripade len zadaju namiesto RC nieco ine co uz uradnici vedia spracovat, preto teraz input iba upozorni na to, ze RC nie je v standardnom formate.

To aby sa defaultne otvarala ciselna klavesnica asi dava zmysel.

@eronisko
Copy link

eronisko commented Aug 2, 2019

Moj nazor je, ze spravme input s tymito validaciami

  • cislo
  • dlzka (9 alebo 10)
  • parsuje na datum

S tym, ze clovek moze zadat rodne cislo s lomitkom aj bez lomitka.

Ostatne validacie by som nateraz vynechal a zaroven podla mna mozeme nateraz vynechat edge cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants