From fc926e2ae66451674af95522126ba521fff68921 Mon Sep 17 00:00:00 2001
From: Dominik Bohuncak <dominik.bohuncak@bootiq.io>
Date: Mon, 2 Oct 2023 11:50:39 +0200
Subject: [PATCH] fix for correct url string for atlassian

---
 application/src/Model/AtlassianIdeaModel.php    | 16 ++++++++--------
 application/src/Model/AtlassianProblemModel.php | 12 +-----------
 2 files changed, 9 insertions(+), 19 deletions(-)

diff --git a/application/src/Model/AtlassianIdeaModel.php b/application/src/Model/AtlassianIdeaModel.php
index 0f61e6b..6f473f0 100644
--- a/application/src/Model/AtlassianIdeaModel.php
+++ b/application/src/Model/AtlassianIdeaModel.php
@@ -6,14 +6,14 @@
 
 class AtlassianIdeaModel implements AttlassianIssueModel
 {
-    private string $serviceDeskId;
-    private string $requestTypeId;
-    private string $summary;
-    private string $description;
-    private string $name;
-    private string $surname;
-    private string $email;
-    private string $phone;
+    protected string $serviceDeskId;
+    protected string $requestTypeId;
+    protected string $summary;
+    protected string $description;
+    protected string $name;
+    protected string $surname;
+    protected string $email;
+    protected string $phone;
 
     public function __construct(
         $summary = '',
diff --git a/application/src/Model/AtlassianProblemModel.php b/application/src/Model/AtlassianProblemModel.php
index 726d77c..b391864 100644
--- a/application/src/Model/AtlassianProblemModel.php
+++ b/application/src/Model/AtlassianProblemModel.php
@@ -6,8 +6,7 @@
 
 class AtlassianProblemModel extends AtlassianIdeaModel
 {
-    private string $url;
-    private string $requestTypeId;
+    protected string $url;
 
     public function __construct(
         $summary = '',
@@ -31,15 +30,6 @@ public function __construct(
         $this->url = $url;
     }
 
-    public function fromArray(array $data = []): void
-    {
-        foreach ($data as $key => $value) {
-            if (property_exists($this, $key)) {
-                $this->{$key} = $value;
-            }
-        }
-    }
-
     public function toArray(): array
     {
         $data = parent::toArray();