From 436e90948cd3e3847f3ef4d765fb45b58539c0c7 Mon Sep 17 00:00:00 2001 From: Simon Hausmann Date: Wed, 23 Oct 2024 10:12:44 +0200 Subject: [PATCH] Pin Python version for Skia builds on macOS The Python version installed on the GH runners via homebrew removes the pipes module, which the Skia build needs until https://github.com/slint-ui/slint/issues/6615 is fixed. --- .github/workflows/cpp_package.yaml | 4 ++++ .github/workflows/nightly_snapshot.yaml | 6 +++++- .github/workflows/publish_npm_package.yaml | 6 +++++- 3 files changed, 14 insertions(+), 2 deletions(-) diff --git a/.github/workflows/cpp_package.yaml b/.github/workflows/cpp_package.yaml index 6d9ac5d66d9..8d199f24a4b 100644 --- a/.github/workflows/cpp_package.yaml +++ b/.github/workflows/cpp_package.yaml @@ -58,6 +58,10 @@ jobs: - name: Prepare licenses run: bash -x ../../scripts/prepare_binary_package.sh ../.. working-directory: api/cpp/ + # Pin Python version until https://github.com/slint-ui/slint/issues/6615 is fixed. + - uses: actions/setup-python@v5 + with: + python-version: '3.12' - uses: ilammy/msvc-dev-cmd@v1 - name: Select MSVC (windows) run: | diff --git a/.github/workflows/nightly_snapshot.yaml b/.github/workflows/nightly_snapshot.yaml index faac71e164e..d5b5d1a2906 100644 --- a/.github/workflows/nightly_snapshot.yaml +++ b/.github/workflows/nightly_snapshot.yaml @@ -141,12 +141,16 @@ jobs: build_vscode_lsp_macos_aarch64: env: SLINT_NO_QT: 1 - runs-on: macos-latest + runs-on: macos-14 steps: - uses: actions/checkout@v4 - uses: ./.github/actions/setup-rust with: target: aarch64-apple-darwin + # Pin Python version until https://github.com/slint-ui/slint/issues/6615 is fixed. + - uses: actions/setup-python@v5 + with: + python-version: '3.12' - name: Build AArch64 LSP run: cargo build --target aarch64-apple-darwin --features ${{ env.SLINT_BINARY_FEATURES }} --release -p slint-lsp - name: Create artifact directory diff --git a/.github/workflows/publish_npm_package.yaml b/.github/workflows/publish_npm_package.yaml index d5d94d20b60..49f1c011fba 100644 --- a/.github/workflows/publish_npm_package.yaml +++ b/.github/workflows/publish_npm_package.yaml @@ -83,7 +83,11 @@ jobs: target: ${{ matrix.rust-target }} - name: Upgrade LLVM for Skia build on Windows if: runner.os == 'Windows' - run: choco upgrade llvm + run: choco upgrade llvm + # Pin Python version until https://github.com/slint-ui/slint/issues/6615 is fixed. + - uses: actions/setup-python@v5 + with: + python-version: '3.12' # Setup .npmrc file to publish to npm - uses: actions/setup-node@v4 with: