From 08a730a224b1f3d6364cfef54981048fa09235fb Mon Sep 17 00:00:00 2001
From: Mitchell Victoriano <mitchell.victoriano@gmail.com>
Date: Thu, 19 Dec 2024 10:45:44 -0800
Subject: [PATCH] Updated existing tasks to preserve file structure

---
 ec2/.gitignore                                |  4 +-
 ec2/README.md                                 | 25 +-----------
 ec2/analysis-tasks/README.md                  |  2 +
 .../az-tilt-estimation/config.json            | 39 -------------------
 .../az-tilt-estimation/data/files/README.md   |  0
 .../data/ground-truth/README.md               |  0
 .../time-shift-detection/data/files/README.md |  0
 .../data/ground-truth/README.md               |  0
 8 files changed, 5 insertions(+), 65 deletions(-)
 create mode 100644 ec2/analysis-tasks/README.md
 create mode 100644 ec2/analysis-tasks/az-tilt-estimation/data/files/README.md
 create mode 100644 ec2/analysis-tasks/az-tilt-estimation/data/ground-truth/README.md
 create mode 100644 ec2/analysis-tasks/time-shift-detection/data/files/README.md
 create mode 100644 ec2/analysis-tasks/time-shift-detection/data/ground-truth/README.md

diff --git a/ec2/.gitignore b/ec2/.gitignore
index 98049ec9..495203eb 100644
--- a/ec2/.gitignore
+++ b/ec2/.gitignore
@@ -1,2 +1,2 @@
-**/data/files/*
-**/data/ground-truth/*
\ No newline at end of file
+**/data/files/*.csv
+**/data/ground-truth/*.csv
\ No newline at end of file
diff --git a/ec2/README.md b/ec2/README.md
index b4c0f067..7bf3da70 100755
--- a/ec2/README.md
+++ b/ec2/README.md
@@ -72,28 +72,6 @@ Example JSON:
     "mean_absolute_error_time_series",
     "data_sampling_frequency",
     "issue"
-  ],
-  "plots": [ 
-    {
-      "type": "histogram",
-      "x_val": "mean_absolute_error_time_series",
-      "color_code": "issue",
-      "title": "Time Series MAE Distribution by Issue",
-      "save_file_path": "mean_absolute_error_time_series_dist.png"
-    },
-    {
-      "type": "histogram",
-      "x_val": "mean_absolute_error_time_series",
-      "color_code": "data_sampling_frequency",
-      "title": "Time Series MAE Distribution by Sampling Frequency",
-      "save_file_path": "mean_absolute_error_time_series_dist.png"
-    },
-    {
-      "type": "histogram",
-      "x_val": "run_time",
-      "title": "Run Time Distribution",
-      "save_file_path": "run_time_dist.png"
-    }
   ]
 }
 ```
@@ -111,12 +89,11 @@ Example JSON:
   - The formatting is as follows `<performance_metric>_<ground_truth_type>`
   - e.g. `mean_absolute_error_time_series`
 - "allowable_kwargs" - kwargs for the submission function that are allowed
-- "ground_truth_compare" - comparrison type that is used for calculating metrics
+- "ground_truth_compare" - results from submission function
 - "public_results_table" - name of json result file that contains information about submission results
 - "private_results_columns" - name of columns that will be in final dataframe that is passed to marimo template
   - will need to contain final metric name to be used in marimo template
   - The formatting is as follows `<metric_operation>_<performance_metric>_<ground_truth_type>`
-- "plots" - not currently used as marimo template is most recent way to visualize results
 
 ### system_metadata.csv
 
diff --git a/ec2/analysis-tasks/README.md b/ec2/analysis-tasks/README.md
new file mode 100644
index 00000000..5256b89d
--- /dev/null
+++ b/ec2/analysis-tasks/README.md
@@ -0,0 +1,2 @@
+# Analysis Task Structure
+
diff --git a/ec2/analysis-tasks/az-tilt-estimation/config.json b/ec2/analysis-tasks/az-tilt-estimation/config.json
index 239cdd40..e280ec29 100644
--- a/ec2/analysis-tasks/az-tilt-estimation/config.json
+++ b/ec2/analysis-tasks/az-tilt-estimation/config.json
@@ -58,44 +58,5 @@
 		"error_tilt",
 		"issue",
 		"number_days"
-	],
-	"plots": [
-		{
-			"type": "histogram",
-			"x_val": "absolute_error_azimuth",
-			"title": "Azimuth Absolute Error Distribution",
-			"save_file_path": "absolute_error_az_dist.png"
-		},
-		{
-			"type": "histogram",
-			"x_val": "absolute_error_tilt",
-			"title": "Tilt Absolute Error Distribution",
-			"save_file_path": "absolute_error_tilt_dist.png"
-		},
-		{
-			"type": "histogram",
-			"x_val": "error_azimuth",
-			"title": "Azimuth Error Distribution",
-			"save_file_path": "absolute_error_az_dist.png"
-		},
-		{
-			"type": "histogram",
-			"x_val": "error_tilt",
-			"title": "Tilt Error Distribution",
-			"save_file_path": "error_tilt_dist.png"
-		},
-		{
-			"type": "histogram",
-			"x_val": "run_time",
-			"title": "Run Time Distribution",
-			"save_file_path": "run_time_dist.png"
-		},
-		{
-			"type": "scatter_plot",
-			"x_val": "run_time",
-			"y_val": "number_days",
-			"title": "Run Time vs. Number Days in Data Set",
-			"save_file_path": "run_time_number_days.png"
-		}
 	]
 }
\ No newline at end of file
diff --git a/ec2/analysis-tasks/az-tilt-estimation/data/files/README.md b/ec2/analysis-tasks/az-tilt-estimation/data/files/README.md
new file mode 100644
index 00000000..e69de29b
diff --git a/ec2/analysis-tasks/az-tilt-estimation/data/ground-truth/README.md b/ec2/analysis-tasks/az-tilt-estimation/data/ground-truth/README.md
new file mode 100644
index 00000000..e69de29b
diff --git a/ec2/analysis-tasks/time-shift-detection/data/files/README.md b/ec2/analysis-tasks/time-shift-detection/data/files/README.md
new file mode 100644
index 00000000..e69de29b
diff --git a/ec2/analysis-tasks/time-shift-detection/data/ground-truth/README.md b/ec2/analysis-tasks/time-shift-detection/data/ground-truth/README.md
new file mode 100644
index 00000000..e69de29b