From 06de6de2d47cbca0f315545262227505fa05920b Mon Sep 17 00:00:00 2001
From: Kihyo Moon <36657450+hyoxt121@users.noreply.github.com>
Date: Fri, 6 Dec 2024 08:43:23 +0900
Subject: [PATCH] [SCP] open port support

---
 sky/skylet/providers/scp/node_provider.py | 60 +++++++++++++++--------
 1 file changed, 40 insertions(+), 20 deletions(-)

diff --git a/sky/skylet/providers/scp/node_provider.py b/sky/skylet/providers/scp/node_provider.py
index 762ee4bfb67..0174a2d537b 100644
--- a/sky/skylet/providers/scp/node_provider.py
+++ b/sky/skylet/providers/scp/node_provider.py
@@ -357,30 +357,50 @@ def _del_firewall_rules(self, firewall_id, rule_ids):
     @_retry_on_creation
     def _add_firewall_inbound(self, firewall_id, internal_ip):
 
-        rule_info = self.scp_client.add_firewall_inbound_rule(
-            firewall_id, internal_ip)
-        rule_id = rule_info['resourceId']
-        while True:
-            time.sleep(5)
-            rule_info = self.scp_client.get_firewall_rule_info(
-                firewall_id, rule_id)
-            if rule_info['ruleState'] == "ACTIVE":
-                break
-        return rule_id
+        attempts = 0
+        max_attempts = 300
+
+        while attempts < max_attempts:
+            try:
+                rule_info = self.scp_client.add_firewall_inbound_rule(
+                    firewall_id, internal_ip)
+                rule_id = rule_info['resourceId']
+                while True:
+                    time.sleep(5)
+                    rule_info = self.scp_client.get_firewall_rule_info(
+                        firewall_id, rule_id)
+                    if rule_info['ruleState'] == "ACTIVE":
+                        break
+                return rule_id
+            except Exception as e:
+                attempts += 1
+                time.sleep(10)
+                continue
+        raise SCPError("Firewall Rule Error")
 
     @_retry_on_creation
     def _add_firewall_outbound(self, firewall_id, internal_ip):
 
-        rule_info = self.scp_client.add_firewall_outbound_rule(
-            firewall_id, internal_ip)
-        rule_id = rule_info['resourceId']
-        while True:
-            time.sleep(5)
-            rule_info = self.scp_client.get_firewall_rule_info(
-                firewall_id, rule_id)
-            if rule_info['ruleState'] == "ACTIVE":
-                break
-        return rule_id
+        attempts = 0
+        max_attempts = 300
+
+        while attempts < max_attempts:
+            try:
+                rule_info = self.scp_client.add_firewall_outbound_rule(
+                    firewall_id, internal_ip)
+                rule_id = rule_info['resourceId']
+                while True:
+                    time.sleep(5)
+                    rule_info = self.scp_client.get_firewall_rule_info(
+                        firewall_id, rule_id)
+                    if rule_info['ruleState'] == "ACTIVE":
+                        break
+                return rule_id
+            except Exception as e:
+                attempts += 1
+                time.sleep(10)
+                continue
+        raise SCPError("Firewall Rule Error")
 
     def _get_firewall_id(self, vpc_id):