Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SK-1691/Release/24.9.3 #174

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

SK-1691/Release/24.9.3 #174

wants to merge 4 commits into from

Conversation

skyflow-vivek
Copy link
Collaborator

This PR contains fix for a bug discovered in card brand choice feature in Android SDK.

Why

  • The onChange listener was not firing after card was selected from drop-down in card brand choice.
  • This is an inconsistency with card brand choice behaviour w.r.t iOS SDK. Therefore, it needs to be addressed.

Goal

  • onChange listener should fire after card is selected from drop-down.
  • onChange listener should fire after drop-down is removed from UI.

Testing

  • Manual testing was done for card brand choice behaviour.
  • Car brand choice is a UI feature hence bug fix scenario couldn't be covered via unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant