Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default culture setting is ignored #211

Open
gregor-tusar-sowa opened this issue Sep 16, 2024 · 0 comments
Open

Default culture setting is ignored #211

gregor-tusar-sowa opened this issue Sep 16, 2024 · 0 comments
Labels
type/bug Something isn't working

Comments

@gregor-tusar-sowa
Copy link

Which version of Skybrud Redirects are you using? (Please write the exact version, example: 4.0.8)

13.0.4

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

13.5.0

Bug description

I have two domains set up DE and EN and a default language set to DE.

image

image

The problem is that if I select specific root node, the redirect with the original URL without domain culture prefix does not work (i.e. /en/test-redirect vs. /test-redirect). If I select All sites it works.

image

I was debugging a bit and found a method SelectDomain in DomainUtils class. It has support for default culture, but looking at the references it is always filled with null value. So in effect the attempt to get domain by default culture in SelectByCulture method is never reached.

I tired to manually change default culture in debugger and it seemd to found the domain correctly.

Is that intentional or is it a bug?

@gregor-tusar-sowa gregor-tusar-sowa added the type/bug Something isn't working label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant