This repository has been archived by the owner on Sep 4, 2024. It is now read-only.

Embed Job to BuildResult type #39

Open

agis opened this issue Apr 18, 2018 · 1 comment

Assignees

Labels

Contributor

agis commented Apr 18, 2018

We already added the job params inside BuildResult{} so it might make sense to add the whole job.

The text was updated successfully, but these errors were encountered:

agis added the idea label

agis self-assigned this

agis added refactor and removed idea labels

Contributor Author

agis commented Sep 26, 2018 •

edited

Loading

To do this, we have to:

extract any server-aware methods from Job into Server or something (to decouple Server from Job)
extract the job type to a package

We should also probably make NewBuildResult accept a job as a parameter, so that we don't have to do the construction in Work().

agis mentioned this issue

Remove BuildInfo.StartedAt #49

Open

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.