Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent updates to decimals for enabled markets #810

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

chenyaoy
Copy link
Contributor

@chenyaoy chenyaoy commented Nov 4, 2024

No description provided.

@chenyaoy chenyaoy requested a review from a team as a code owner November 4, 2024 21:57
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 36.36364% with 7 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@c5b2cfc). Learn more about missing BASE report.

Files with missing lines Patch % Lines
x/marketmap/types/errors.go 0.00% 4 Missing ⚠️
x/marketmap/keeper/keeper.go 57.14% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #810   +/-   ##
=======================================
  Coverage        ?   57.38%           
=======================================
  Files           ?      214           
  Lines           ?    14836           
  Branches        ?        0           
=======================================
  Hits            ?     8513           
  Misses          ?     5709           
  Partials        ?      614           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@zrbecker zrbecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are going to reflect on this change a bit before accepting since in it's current form it would not be optional and if we needed to update decimals for any reason this prevents it completely. Perhaps it should be allow via governance update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants