Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a faster method for tx containment checks #503

Open
ValarDragon opened this issue May 24, 2024 · 0 comments
Open

Use a faster method for tx containment checks #503

ValarDragon opened this issue May 24, 2024 · 0 comments

Comments

@ValarDragon
Copy link
Contributor

ValarDragon commented May 24, 2024

We should use a faster method for determining if a tx is in the app-side mempool. This is too costly for recheck as it stands

The following come to mind

  • Try caching the tx hashes of all txs that passed CheckTx .
    • Cache thrashing is a concern, so I think it should be done in conjunction with at minimum using a faster hash (if we can't get away with a non-cryptographic hash)
  • Entirely remove the proto marshal, I don't see why we need it, given that we are taking a hash of deterministic bytes.
  • Use a faster cryptographic hash (Blake3)
  • Use a non-cryptographic much faster hash, and be ok with collisions (Would need analysis, so would rather try the above and see where we get)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant