You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The interface mev.Factory is currently used in the package abci/checktx. I believe it would be better for the abci/checktx package to declare its own interface because:
The abci/checktx package doesn't use all the methods of the mev.Factory interface. It would be more efficient to declare an interface that suits its specific needs.
By declaring its own interface, the abci/checktx package can avoid importing the dependency on mev.Factory.
The text was updated successfully, but these errors were encountered:
EmilGeorgiev
changed the title
Consider declaration and usage of the interface of the interface
Consider Declaring the Interface mev.Factory Locally
May 20, 2024
EmilGeorgiev
changed the title
Consider Declaring the Interface mev.Factory Locally
Consider Declaring the Interface Factory locally
May 20, 2024
The interface mev.Factory is currently used in the package abci/checktx. I believe it would be better for the abci/checktx package to declare its own interface because:
The abci/checktx package doesn't use all the methods of the mev.Factory interface. It would be more efficient to declare an interface that suits its specific needs.
By declaring its own interface, the abci/checktx package can avoid importing the dependency on mev.Factory.
This approach follows Go best practices as outlined here Go Style Guide - Interfaces.
The text was updated successfully, but these errors were encountered: