Fix event handling in stack example #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The help text in the stack example suggests clicking on the windows but this did not do anything as raw click events were expected while the terminal was not in raw mouse event mode. Let the model respond to the SingleClick event instead of the MousePress so click messages are shown. Rearrange the print order and clear the background of widgets so that the borders of the widgets in the lower stack are not shown through and the end of the previous click message does not remain showing when the next click is registered. This combined with listening to resize events also allows the layout to remain consistent when the terminal is resized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few minor (imo) improvements for the stack example.
Happy to rework if you'd like it done differently (or not at all).