Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra parameters to model discards #274

Closed
gustavdelius opened this issue Dec 7, 2022 · 2 comments
Closed

Extra parameters to model discards #274

gustavdelius opened this issue Dec 7, 2022 · 2 comments
Labels
enhancement New feature requests or suggestions for enhancement of existing features

Comments

@gustavdelius
Copy link
Member

In addition to the selectivity curve which, when combined with the size distribution of the species, determines the size distribution of the catches, there should also be a selectivity curve that models which of the caught fish are selected to be landed. The size distribution of the landed catch would then be obtained as the product of the size distribution of the catch with this additional landings selectivity curve. I propose that this curve should simply be a sigmoidal curve, parametrised by new gear parameters landings_l50 and landings_l25. These new parameters will be used by getYield() but will be irrelevant for the calculation of the fishing mortality.

In addition to yield_observed we should also have a discard_observed column in the gear_params data frame, giving the rate at which biomass is discarded.

@gustavdelius gustavdelius added the enhancement New feature requests or suggestions for enhancement of existing features label Dec 7, 2022
@gustavdelius
Copy link
Member Author

gustavdelius commented Apr 3, 2024

I believe this will require the following:

  • In getYieldGear() check if there is a gear parameter landings_l50. If so, set default for landings_l25 if necessary, calculate the landings sigmoid that gives the proportion of the catch that is landed and multiply the current yield by this function before returning.
  • Add getDiscardsGear() and getDiscards() functions.
  • Add an include_discards = FALSE argument to plotYield(). If called with include_discards = TRUE, add an extra curve for the discards.
  • In the documentation for gear_params() mention the new optional landings_l50 and landings_l25 parameters.
  • Search for any use of getFMort() that might be used to implement a yield calculation bypassing getYield(). If found, this needs to be changed.
  • Add tests
  • Update NEWS.md
  • Make changes in mizerExperimental

@gustavdelius
Copy link
Member Author

I have decided to develop this in mizerExperimental, see sizespectrum/mizerExperimental#65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature requests or suggestions for enhancement of existing features
Projects
None yet
Development

No branches or pull requests

1 participant