Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use resource parameter names w_min and w_max #235

Open
gustavdelius opened this issue Sep 30, 2021 · 0 comments
Open

Use resource parameter names w_min and w_max #235

gustavdelius opened this issue Sep 30, 2021 · 0 comments
Labels
enhancement New feature requests or suggestions for enhancement of existing features minor effort Resolving this issue will involve a minor effort
Milestone

Comments

@gustavdelius
Copy link
Member

Currently mizer uses the names min_w_pp and w_pp_cutoff whereas mizerMR uses w_min and w_max. The _pp subscript does not make much sense and I would like to harmonise the resource parameters between mizer and mizerMR. Therefore we should also add a w_min column to the list returned by resource_params().

@gustavdelius gustavdelius added this to the Version 2.4 milestone Nov 2, 2022
@gustavdelius gustavdelius added enhancement New feature requests or suggestions for enhancement of existing features minor effort Resolving this issue will involve a minor effort labels Nov 2, 2022
@gustavdelius gustavdelius modified the milestones: Version 2.4, Version 3.0 Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature requests or suggestions for enhancement of existing features minor effort Resolving this issue will involve a minor effort
Projects
None yet
Development

No branches or pull requests

1 participant