update with new default parameters #221
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsvilas
reviewed
Mar 8, 2023
| @@ -17,6 +17,7 @@ class AppDelegate: UIResponder, UIApplicationDelegate { | |||
|
|
|||
| func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?) -> Bool { | |||
| // Override point for customization after application launch. | |||
| SITServices.setUseRemoteConfig(true) | |||
There was a problem hiding this comment.
Esta é a aplicación de exemplo de WYF, se activas a configRemota no AppDelegate, non despistaría un pouco a aqueles que esten probando os exemplos.
Non sei se sería posible meter algunha forma para activar/desactivar a config remota dende a UI e se cadra explicalo no readme?
| } |
There was a problem hiding this comment.
Estes iconos son de Situm? O ser un repo público tería coidado co icono de app que se sube
| @@ -32,9 +32,10 @@ class WayfindingController: UIViewController { | |||
| let settings = LibrarySettings.Builder() | |||
| .setCredentials(credentials: credentials) | |||
| .setBuildingId(buildingId: buildingId) | |||
There was a problem hiding this comment.
Non comentaria estes set, polo de antes, é unha app de exemplo e a xente podelle interesar ver como se establecen eses valores
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.