Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of multiple dispatch and nothing #26

Open
MaximeBouton opened this issue Oct 10, 2019 · 0 comments
Open

Use of multiple dispatch and nothing #26

MaximeBouton opened this issue Oct 10, 2019 · 0 comments

Comments

@MaximeBouton
Copy link
Member

I think there are a couple type checks and if statements that could be handled by multiple dispatch as well as some checks for boolean that could use nothing or missing instead.

Examples of lines that could use nothing:
https://github.com/sisl/GaussianFilters.jl/blob/master/src/kf.jl#L57
https://github.com/sisl/GaussianFilters.jl/blob/master/src/kf.jl#L56

Examples of lines that could use multiple dispatch:
https://github.com/sisl/GaussianFilters.jl/blob/master/src/ukf.jl#L27
https://github.com/sisl/GaussianFilters.jl/blob/master/src/ukf.jl#L218
https://github.com/sisl/GaussianFilters.jl/blob/master/src/ukf.jl#L225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant